feat: base RN upgrades experience #36
Conversation
src/tools/react-native.ts
Outdated
| project, | ||
| platforms, | ||
| } = await loadReactNativeConfig() | ||
| const { root, reactNativePath: path, project, platforms } = await loadReactNativeConfig() |
There was a problem hiding this comment.
Turns out React Native CLI is lying with versions (I was on 0.76.3 and it returns 0.76), it's better for AI to figure it out based on package.json
There was a problem hiding this comment.
Do we know why? That is weird
okwasniewski
force-pushed
the
feat/rn-upgrades
branch
from
9a820cd to
a30feb5
Compare
| action: dedent` | ||
| Go over user file tree and apply diffs to the project. | ||
| `, | ||
| diff, |
There was a problem hiding this comment.
save diff into file in os.tmp() and return path here.
| action: dedent` | ||
| Go over user file tree and apply diffs to the project. | ||
| `, | ||
| diff, |
There was a problem hiding this comment.
nit: in the future, we will need to unify our response formats. I think since AIs are conversational ,we can safely return Go over diff at path ${path} instead of returning it as an extra property
| Upgrade React Native diff tool, returns a diff between two versions of React Native. | ||
|
|
||
| Parameters: | ||
| - "from" - source version, (Read the exact version from package.json using "readFile" tool). Example: "0.75.0" |
There was a problem hiding this comment.
nit: I typically use this format just for Returns, because there's no validation. For parameters, I would just put this on the schema with zod.describe
| success: true, | ||
| action: dedent` | ||
| Ask user to select a version from the list. | ||
| `, |
There was a problem hiding this comment.
nit: no need for decent if single line.
Also, we can try Ask user to select a version from the list: ${mappedList} if it works .
This is all serialized to string anyway at the end of the day
This PR implements base React Native upgrades experience.
I was hitting token limits so it's not working perfectly.
Things to fix:
messagesso that they don't hit the limit especially if we have instructions with large patches