Skip to content

Commit

Permalink
revert public diffs changes
Browse files Browse the repository at this point in the history
  • Loading branch information
thymikee committed Sep 12, 2024
1 parent 8548cc1 commit 7a2a670
Show file tree
Hide file tree
Showing 2 changed files with 17 additions and 17 deletions.
16 changes: 8 additions & 8 deletions website/src/public/diffs/repack_v1-v2.diff
Original file line number Diff line number Diff line change
Expand Up @@ -33,21 +33,21 @@ index 8373e9e..6ff525d 100644
/**
* This is the Webpack configuration file for your React Native project.
* It can be used in 2 ways:
* - by running React Native Community CLI eg: `npx react-native start` or `npx react-native bundle`
* - by running React Native CLI eg: `npx react-native start` or `npx react-native bundle`
- * - by running Webpack CLI eg: `npx webpack-cli -c webpack.config.js`
+ * - by running Webpack CLI eg: `PLATFORM=(ios|android) npx webpack-cli -c webpack.config.js`
*
* Depending on which option you chose the output might be different, since when running with
- * React Native Community CLI most of the values from `parseCliOptions` will be filled in by React Native Community CLI.
+ * React Native Community CLI most of the values from `getMode`, `getPlatform`, etc. will be filled in by React Native Community CLI.
- * React Native CLI most of the values from `parseCliOptions` will be filled in by React Native CLI.
+ * React Native CLI most of the values from `getMode`, `getPlatform`, etc. will be filled in by React Native CLI.
* However, when running with Webpack CLI, you might want to tweak `fallback` values to your liking.
*
* Please refer to the API documentation for list of options, plugins and their descriptions.
*/

/**
- * Get options from React Native Community CLI when Webpack is run from `react-native start` or `react-native bundle`
+ * Get options from React Native Community CLI when Webpack is run from `react-native start` or `react-native bundle`.
- * Get options from React Native CLI when Webpack is run from `react-native start` or `react-native bundle`
+ * Get options from React Native CLI when Webpack is run from `react-native start` or `react-native bundle`.
*
- * If you run Webpack using Webpack CLI the default and fallback values will be used - use `fallback`
- * to specify your values if the default's doesn't suit your project.
Expand Down Expand Up @@ -129,7 +129,7 @@ index 8373e9e..6ff525d 100644
},
/**
* Configures output.
- * Unless you don't want to use output values passed from React Native Community CLI, it's recommended to
- * Unless you don't want to use output values passed from React Native CLI, it's recommended to
- * leave it as it is.
+ * It's recommended to leave it as it is unless you know what you're doing.
+ * By default Webpack will emit files into the directory specified under `path`. In order for the
Expand Down Expand Up @@ -247,7 +247,7 @@ index 8373e9e..6ff525d 100644
+ /**
+ * By default Webpack will emit files into `output.path` directory (eg: `<root>/build/ios`),
+ * but in order to for the React Native application to include those files (or a subset of those)
+ * they need to be copied over to correct output directories supplied from React Native Community CLI
+ * they need to be copied over to correct output directories supplied from React Native CLI
+ * when bundling the code (with `webpack-bundle` command).
+ * All remote chunks will be placed under `remoteChunksOutput` directory (eg: `<root>/build/<platform>/remote` by default).
+ * In development mode (when development server is running), this plugin is a no-op.
Expand All @@ -259,7 +259,7 @@ index 8373e9e..6ff525d 100644
+ }),

/**
* Runs development server when running with React Native Community CLI start command or if `devServer`
* Runs development server when running with React Native CLI start command or if `devServer`
* was provided as s `fallback`.
*/
- new DevServerPlugin({
Expand Down
18 changes: 9 additions & 9 deletions website/src/public/diffs/repack_v2-v3.diff
Original file line number Diff line number Diff line change
Expand Up @@ -17,24 +17,24 @@ index 6ff525d..af917c4 100644
/**
- * This is the Webpack configuration file for your React Native project.
- * It can be used in 2 ways:
- * - by running React Native Community CLI eg: `npx react-native start` or `npx react-native bundle`
- * - by running React Native CLI eg: `npx react-native start` or `npx react-native bundle`
- * - by running Webpack CLI eg: `PLATFORM=(ios|android) npx webpack-cli -c webpack.config.js`
- *
- * Depending on which option you chose the output might be different, since when running with
- * React Native Community CLI most of the values from `getMode`, `getPlatform`, etc. will be filled in by React Native Community CLI.
- * React Native CLI most of the values from `getMode`, `getPlatform`, etc. will be filled in by React Native CLI.
- * However, when running with Webpack CLI, you might want to tweak `fallback` values to your liking.
- *
- * Please refer to the API documentation for list of options, plugins and their descriptions.
- */
-
-/**
- * Get options from React Native Community CLI when Webpack is run from `react-native start` or `react-native bundle`.
- * Get options from React Native CLI when Webpack is run from `react-native start` or `react-native bundle`.
+ * Webpack configuration.
+ * You can also export a static object or a function returning a Promise.
*
- * If you run Webpack using Webpack CLI, the values from `fallback` will be used - use it
- * to specify your values, if the defaults don't suit your project.
+ * @param env Environment options passed from either Webpack CLI or React Native Community CLI
+ * @param env Environment options passed from either Webpack CLI or React Native CLI
+ * when running with `react-native start/bundle`.
*/
+module.exports = (env) => {
Expand Down Expand Up @@ -159,7 +159,7 @@ index 6ff525d..af917c4 100644
- * Configures optimization of the built bundle.
- */
- optimization: {
- /** Enables minification based on values passed from React Native Community CLI or from fallback. */
- /** Enables minification based on values passed from React Native CLI or from fallback. */
- minimize,
- /** Configure minimizer to process the bundle. */
- minimizer: [
Expand Down Expand Up @@ -243,7 +243,7 @@ index 6ff525d..af917c4 100644
- use: 'babel-loader',
- },
+ optimization: {
+ /** Enables minification based on values passed from React Native Community CLI or from fallback. */
+ /** Enables minification based on values passed from React Native CLI or from fallback. */
+ minimize,
+ /** Configure minimizer to process the bundle. */
+ minimizer: [
Expand Down Expand Up @@ -422,7 +422,7 @@ index 6ff525d..af917c4 100644
- /**
- * By default Webpack will emit files into `output.path` directory (eg: `<root>/build/ios`),
- * but in order to for the React Native application to include those files (or a subset of those)
- * they need to be copied over to correct output directories supplied from React Native Community CLI
- * they need to be copied over to correct output directories supplied from React Native CLI
- * when bundling the code (with `webpack-bundle` command).
- * All remote chunks will be placed under `remoteChunksOutput` directory (eg: `<root>/build/<platform>/remote` by default).
- * In development mode (when development server is running), this plugin is a no-op.
Expand All @@ -434,7 +434,7 @@ index 6ff525d..af917c4 100644
- }),
-
- /**
- * Runs development server when running with React Native Community CLI start command or if `devServer`
- * Runs development server when running with React Native CLI start command or if `devServer`
- * was provided as s `fallback`.
- */
- new ReactNative.DevServerPlugin({
Expand All @@ -444,7 +444,7 @@ index 6ff525d..af917c4 100644
-
- /**
- * Configures Source Maps for the main bundle based on CLI options received from
- * React Native Community CLI or fallback value..
- * React Native CLI or fallback value..
- * It's recommended to leave the default values, unless you know what you're doing.
- * Wrong options might cause symbolication of stack trace inside React Native app
- * to fail - the app will still work, but you might not get Source Map support.
Expand Down

0 comments on commit 7a2a670

Please sign in to comment.