Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add force push next toast functional #410

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ivan-zeller
Copy link

When the application has some functionality, as in the video - the user presses a button to show a toast with the text of this button. When the button is pressed, the toaster is displayed for a while, and when the user presses another button while the toaster is displayed, the previous toast is not hidden, but only changes the text without animation. We need to hide the previous toast and show the next one with animation.

How it works without a patch
https://drive.google.com/file/d/1ZYm6SfcblQaxDTcLuEHqcsaq_a2bv78i/view?usp=sharing
How it works with a patch
https://drive.google.com/file/d/1bAlti2UUwiriLR1fp0o1inMtCoD7dBrY/view?usp=sharing

@TheNerdGuyLulu
Copy link

@ivan-zeller Please, don't forget to add this new prop to the Doc 😉

@AngCosmin
Copy link

Can we merge this one?

@AlejandroGutierrezB
Copy link

Can we merge this one?

I am also interested in having this merged, if the only thing missing is adding those props to the docs I can do it myself

let me know @calintamas

@JanRajtr
Copy link

JanRajtr commented Aug 9, 2023

Any idea when this might be merged?

@saaymeen
Copy link

saaymeen commented Oct 9, 2024

Any ETA on this one? Important to visually indicate that a new toast has been created, even if the content is the same. I use the lib to communicate API errors (e.g. wrong OTP entered) and the toast component does not change if the user enters a wrong OTP twice, resulting in bad UX because there is no visual feedback provided on the second attempt.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants