feat: Delete the booking history of past meetings #18787 #19118

PAVANNAIK25 · 2025-02-05T17:53:51Z

What does this PR do?

Fixes [CAL-5114] Delete the booking history of past meetings #18787 Delete the booking history of past meetings
Fixes CAL-5114

Mandatory Tasks (DO NOT REMOVE)

I have self-reviewed the code (A decent size PR without self-review might be rejected).
I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox. N/A
I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

Are there environment variables that should be set? - No, special env.
What are the minimal test data to have?
- You must have at least one bookings in past.
What is expected (happy path) to have (input and output)?
- On click of edit in past bookings section on bookings page. The delete booking history which delete the same booking from past history.
Any other important info that could help to test that PR
- Feature PR as per the above requirement from @PeerRich: Added a delete button under the edit section for past bookings. Implemented both the UI and backend functionality to allow deleting a single past booking. The delete option is available only for past bookings

/claim #18787

…at/delete-booking-history-past

vercel · 2025-02-05T17:53:57Z

Someone is attempting to deploy a commit to the cal-staging Team on Vercel.

A member of the Team first needs to authorize it.

CLAassistant · 2025-02-05T17:53:58Z

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
3 out of 4 committers have signed the CLA.

✅ anikdhabal
✅ TusharBhatt1
✅ PAVANNAIK25
❌ Pavan

Pavan seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

github-actions · 2025-02-05T17:54:03Z

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

Unknown release type "Feature" found in pull request title "Feature: Delete the booking history of past or canceled meetings #18787". 

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

graphite-app · 2025-02-05T17:55:10Z

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (02/05/25)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add foundation team as reviewer" took an action on this PR • (02/05/25)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (02/05/25)

1 label was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (02/19/25)

1 label was added to this PR based on Keith Williams's automation.

PAVANNAIK25 · 2025-02-06T07:25:05Z

@PeerRich @CarinaWolli Please review my PR. As per requirement mentioned, I have implemented delete functionality to past booking. Let me know if any changes are needed to merge this PR.

TusharBhatt1

@PAVANNAIK25 Can you add a quick loom video !

PAVANNAIK25 · 2025-02-16T18:38:50Z

Hi @TusharBhatt1

Here is the Loom video. Please let me know if anything else is needed from my side.

Video: https://www.loom.com/share/4129a7614a204d1581d5c436c8747b79?sid=4cdf4030-4f87-46a6-9bab-0bdf374023f6

TusharBhatt1 · 2025-02-16T18:43:39Z

Hi @TusharBhatt1

Here is the Loom video. Please let me know if anything else is needed from my side.

Video: https://www.loom.com/share/4129a7614a204d1581d5c436c8747b79?sid=4cdf4030-4f87-46a6-9bab-0bdf374023f6

Nice , will review. Also have you manually added text variables to all the languages , if yes , it’s only required to be added inside en (english) , rest is managed automatically

PAVANNAIK25 · 2025-02-16T18:46:19Z

Nice , will review. Also have you manually added text variables to all the languages , if yes , it’s only required to be added inside en (english) , rest is managed automatically

Should I remove from the other languages?

TusharBhatt1 · 2025-02-16T18:47:33Z

Nice , will review. Also have you manually added text variables to all the languages , if yes , it’s only required to be added inside en (english) , rest is managed automatically

Should I remove from the other languages?

Yes.
Secondly the loom video shows deletion for past bookings , is it for canceled bookings as well ?

PAVANNAIK25 · 2025-02-16T18:50:41Z

Yes. Secondly the loom video shows deletion for past bookings , is it for canceled bookings as well ?

Currently, it is only for the past bookings. Since in the issue Peer Richelsen mentioned to add in past bookings.

TusharBhatt1 · 2025-02-16T18:54:43Z

Yes. Secondly the loom video shows deletion for past bookings , is it for canceled bookings as well ?

Currently, it is only for the past bookings. Since in the issue Peer Richelsen mentioned to add in past bookings.

Cool , just make sure your implementation is dynamic , so that can be used for other type of bookings as well.
Will review in some time.

PAVANNAIK25 · 2025-02-16T20:16:26Z

Cool , just make sure your implementation is dynamic , so that can be used for other type of bookings as well.
Will review in some time.

I have removed the text variables from all other languages. I believe the implementation is dynamic, however, if you feel any changes are required, please let me know.

Thank you😊

apps/web/components/booking/BookingListItem.tsx

…/PAVANNAIK25/cal.com into feat/delete-booking-history-past

PAVANNAIK25 · 2025-02-19T11:35:43Z

@TusharBhatt1 I have corrected the title.

TusharBhatt1 · 2025-02-19T11:58:53Z

@TusharBhatt1 I have corrected the title.

I was referring to :

PAVANNAIK25 · 2025-02-19T13:02:12Z

I was referring to :

Ohh my bad. I have added below in common.json.

"delete_history_title": "Delete booking history",
 "delete_history_description": "Are you sure you want to delete this from your booking history?",
 "unable_to_delete_booking": "Unable to delete booking",
 "booking_delete_successfully": "Booking deleted successfully"

Please confirm only title needs to be changed or others too.

TusharBhatt1 · 2025-02-19T13:12:15Z

I was referring to :

Ohh my bad. I have added below in common.json.
"delete_history_title": "Delete booking history",
 "delete_history_description": "Are you sure you want to delete this from your booking history?",
 "unable_to_delete_booking": "Unable to delete booking",
 "booking_delete_successfully": "Booking deleted successfully"
 
Please confirm only title needs to be changed or others too.

"delete_history_title": "Delete booking history" not required we already have "delete" , kindly use that , rest looks fine

PAVANNAIK25 · 2025-02-19T13:50:09Z

"delete_history_title": "Delete booking history" not required we already have "delete" , kindly use that , rest looks fine

https://www.loom.com/share/867558eaedd44170bd88f12135892f01?sid=a3938b07-5cc4-407a-9508-3171820a0c8c

does it looks good to you?

TusharBhatt1 · 2025-02-19T13:54:06Z

"delete_history_title": "Delete booking history" not required we already have "delete" , kindly use that , rest looks fine

https://www.loom.com/share/867558eaedd44170bd88f12135892f01?sid=a3938b07-5cc4-407a-9508-3171820a0c8c

does it looks good to you?

Let's make the title from "Delete?" to "Delete booking?" (similar to event-type) , just make sure it works well on dark mode as well
Rest LGTM

PAVANNAIK25 · 2025-02-19T14:09:03Z

Please confirm below.

Delete Button

Delete Dialog

TusharBhatt1 · 2025-02-19T14:36:43Z

Please confirm below.

Delete Button

Delete Dialog

Perfect !

apps/web/public/static/locales/en/common.json

apps/web/public/static/locales/he/common.json

…/PAVANNAIK25/cal.com into feat/delete-booking-history-past

packages/trpc/server/routers/viewer/bookings/deleteBooking.handler.ts

PAVANNAIK25 · 2025-02-27T15:06:40Z

@TusharBhatt1 Can you please help me to merge current main into this branch?

github-actions · 2025-03-03T08:56:22Z

E2E results are ready!

Workflow #49790.1 latest results

Pavan added 2 commits February 5, 2025 22:25

Add delete button functionality to past bookings

ab424a7

Merge branch 'main' of https://github.com/PAVANNAIK25/cal.com into fe…

65497f9

…at/delete-booking-history-past

graphite-app bot added the community Created by Linear-GitHub Sync label Feb 5, 2025

graphite-app bot requested review from a team February 5, 2025 17:53

algora-pbc bot mentioned this pull request Feb 5, 2025

[CAL-5114] Delete the booking history of past meetings #18787

Open

algora-pbc bot added the 🙋 Bounty claim label Feb 5, 2025

github-actions bot added ✨ feature New feature or request 💎 Bounty A bounty on Algora.io labels Feb 5, 2025

dosubot bot added the i18n area: i18n, translations label Feb 5, 2025

dosubot bot added this to the v5.0 milestone Feb 5, 2025

PAVANNAIK25 changed the title ~~Feature: Delete the booking history of past or canceled meetings #18787~~ feat: Delete the booking history of past or canceled meetings #18787 Feb 5, 2025

TusharBhatt1 reviewed Feb 16, 2025

View reviewed changes

PAVANNAIK25 added 2 commits February 17, 2025 01:07

Remove text variables from other languages

559639f

add handler whwere offer seats case is handled

ad18631

Merge branch 'main' into feat/delete-booking-history-past

9c7906c

TusharBhatt1 changed the title ~~feat: Delete the booking history of past or canceled meetings #18787~~ feat: Delete the booking history of past meetings #18787 Feb 17, 2025

TusharBhatt1 reviewed Feb 17, 2025

View reviewed changes

apps/web/components/booking/BookingListItem.tsx Outdated Show resolved Hide resolved

PAVANNAIK25 added 2 commits February 19, 2025 17:02

Correct title for test

485ce0e

Merge branch 'feat/delete-booking-history-past' of https://github.com…

342b264

…/PAVANNAIK25/cal.com into feat/delete-booking-history-past

fix title and description

b1e4737

TusharBhatt1 previously approved these changes Feb 19, 2025

View reviewed changes

TusharBhatt1 mentioned this pull request Feb 19, 2025

feat: delete past bookings #19120

Closed

3 tasks

graphite-app bot added the ready-for-e2e label Feb 19, 2025

Merge branch 'main' into feat/delete-booking-history-past

cc2787a

TusharBhatt1 added the high-risk Requires approval by Foundation team label Feb 19, 2025

anikdhabal reviewed Feb 19, 2025

View reviewed changes

apps/web/public/static/locales/en/common.json Outdated Show resolved Hide resolved

anikdhabal reviewed Feb 19, 2025

View reviewed changes

apps/web/public/static/locales/he/common.json Outdated Show resolved Hide resolved

PAVANNAIK25 added 2 commits February 19, 2025 23:53

Remove unnecessary changes in locales

4e1a396

Merge branch 'feat/delete-booking-history-past' of https://github.com…

013eef1

…/PAVANNAIK25/cal.com into feat/delete-booking-history-past

PAVANNAIK25 dismissed TusharBhatt1’s stale review via 013eef1 February 19, 2025 18:26

Merge branch 'main' into feat/delete-booking-history-past

3200003

TusharBhatt1 previously approved these changes Feb 21, 2025

View reviewed changes

anikdhabal requested changes Feb 21, 2025

View reviewed changes

packages/trpc/server/routers/viewer/bookings/deleteBooking.handler.ts Show resolved Hide resolved

Merge branch 'main' into feat/delete-booking-history-past

d74432c

Merge branch 'main' into feat/delete-booking-history-past

ac4c6ec

anikdhabal dismissed TusharBhatt1’s stale review via ac4c6ec March 3, 2025 08:30

Update common.json

19a45f9

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Delete the booking history of past meetings #18787 #19118

feat: Delete the booking history of past meetings #18787 #19118

PAVANNAIK25 commented Feb 5, 2025 •

edited by TusharBhatt1

Loading

vercel bot commented Feb 5, 2025

CLAassistant commented Feb 5, 2025 •

edited

Loading

github-actions bot commented Feb 5, 2025

graphite-app bot commented Feb 5, 2025 •

edited

Loading

PAVANNAIK25 commented Feb 6, 2025

TusharBhatt1 left a comment

PAVANNAIK25 commented Feb 16, 2025

TusharBhatt1 commented Feb 16, 2025

PAVANNAIK25 commented Feb 16, 2025

TusharBhatt1 commented Feb 16, 2025

PAVANNAIK25 commented Feb 16, 2025

TusharBhatt1 commented Feb 16, 2025

PAVANNAIK25 commented Feb 16, 2025

PAVANNAIK25 commented Feb 19, 2025

TusharBhatt1 commented Feb 19, 2025

PAVANNAIK25 commented Feb 19, 2025

TusharBhatt1 commented Feb 19, 2025

PAVANNAIK25 commented Feb 19, 2025

TusharBhatt1 commented Feb 19, 2025

PAVANNAIK25 commented Feb 19, 2025 •

edited

Loading

TusharBhatt1 commented Feb 19, 2025

PAVANNAIK25 commented Feb 27, 2025

github-actions bot commented Mar 3, 2025

feat: Delete the booking history of past meetings #18787 #19118

Are you sure you want to change the base?

feat: Delete the booking history of past meetings #18787 #19118

Conversation

PAVANNAIK25 commented Feb 5, 2025 • edited by TusharBhatt1 Loading

What does this PR do?

Mandatory Tasks (DO NOT REMOVE)

How should this be tested?

vercel bot commented Feb 5, 2025

CLAassistant commented Feb 5, 2025 • edited Loading

github-actions bot commented Feb 5, 2025

graphite-app bot commented Feb 5, 2025 • edited Loading

Graphite Automations

PAVANNAIK25 commented Feb 6, 2025

TusharBhatt1 left a comment

Choose a reason for hiding this comment

PAVANNAIK25 commented Feb 16, 2025

TusharBhatt1 commented Feb 16, 2025

PAVANNAIK25 commented Feb 16, 2025

TusharBhatt1 commented Feb 16, 2025

PAVANNAIK25 commented Feb 16, 2025

TusharBhatt1 commented Feb 16, 2025

PAVANNAIK25 commented Feb 16, 2025

PAVANNAIK25 commented Feb 19, 2025

TusharBhatt1 commented Feb 19, 2025

PAVANNAIK25 commented Feb 19, 2025

TusharBhatt1 commented Feb 19, 2025

PAVANNAIK25 commented Feb 19, 2025

TusharBhatt1 commented Feb 19, 2025

PAVANNAIK25 commented Feb 19, 2025 • edited Loading

TusharBhatt1 commented Feb 19, 2025

PAVANNAIK25 commented Feb 27, 2025

github-actions bot commented Mar 3, 2025

E2E results are ready!

PAVANNAIK25 commented Feb 5, 2025 •

edited by TusharBhatt1

Loading

CLAassistant commented Feb 5, 2025 •

edited

Loading

graphite-app bot commented Feb 5, 2025 •

edited

Loading

PAVANNAIK25 commented Feb 19, 2025 •

edited

Loading