chore: migrate orgDomain instant meeting route to App Router #19067
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
2 Skipped Deployments
|
hbjORbj
changed the title
hbjORbj
commented
Feb 3, 2025
| return ( | ||
| <main className={getBookerWrapperClasses({ isEmbed: !!isEmbed })}> | ||
| <BookerSeo |
There was a problem hiding this comment.
replaced by generateMetadata in App router route
hbjORbj
commented
Feb 3, 2025
| @@ -55,6 +55,7 @@ export const getServerSideProps = async (context: GetServerSidePropsContext) => | |||
|
|
|||
| return { | |||
| props: { | |||
| eventData, | |||
There was a problem hiding this comment.
By making this passed from getServerSideProps, we can use this to generate metadata without another extra query fetching in generateMetadata
E2E results are ready! |
hbjORbj
changed the title
MuhammadAimanSulaiman
pushed a commit
to hit-pay/cal.com
that referenced
this pull request
Feb 25, 2025
…19067) * Remove BookerSeo from instant-meeting-view * remove route from pages router * make eventData passed from getServerSideProps * refactor route in app router and move it outside of /future
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
app/org/[orgSlug]/instant-meeting/team/[slug]/[type]/page.tsxTested
Mandatory Tasks (DO NOT REMOVE)
How should this be tested?
/org/[orgSlug]/instant-meeting/team/[slug]/[type]