Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Remove rate workflow from free workflow templates and ask to upgrade to teams plan or above. #19066

Open
wants to merge 7 commits into
base: main
Choose a base branch
from

Conversation

Jynx2004
Copy link

@Jynx2004 Jynx2004 commented Feb 3, 2025

What does this PR do?

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my changes generate no new warnings

@CLAassistant
Copy link

CLAassistant commented Feb 3, 2025

CLA assistant check
All committers have signed the CLA.

Copy link

vercel bot commented Feb 3, 2025

@Jynx2004 is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

Copy link
Contributor

github-actions bot commented Feb 3, 2025

Hey there and thank you for opening this pull request! 👋🏼

We require pull request titles to follow the Conventional Commits specification and it looks like your proposed title needs to be adjusted.

Details:

No release type found in pull request title "[CAL-5121] Remove rate workflow from free workflow templates and ask to upgrade to teams plan or above. #19063". Add a prefix to indicate what kind of release this pull request corresponds to. For reference, see https://www.conventionalcommits.org/

Available types:
 - feat: A new feature
 - fix: A bug fix
 - docs: Documentation only changes
 - style: Changes that do not affect the meaning of the code (white-space, formatting, missing semi-colons, etc)
 - refactor: A code change that neither fixes a bug nor adds a feature
 - perf: A code change that improves performance
 - test: Adding missing tests or correcting existing tests
 - build: Changes that affect the build system or external dependencies (example scopes: gulp, broccoli, npm)
 - ci: Changes to our CI configuration files and scripts (example scopes: Travis, Circle, BrowserStack, SauceLabs)
 - chore: Other changes that don't modify src or test files
 - revert: Reverts a previous commit

@github-actions github-actions bot added insights area: insights, analytics Medium priority Created by Linear-GitHub Sync workflows area: workflows, automations 🧹 Improvements Improvements to existing features. Mostly UX/UI ❗️ .env changes contains changes to env variables labels Feb 3, 2025
@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Feb 3, 2025
@graphite-app graphite-app bot requested a review from a team February 3, 2025 20:18
Copy link

graphite-app bot commented Feb 3, 2025

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (02/03/25)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (02/03/25)

1 label was added to this PR based on Keith Williams's automation.

@retrogtx
Copy link
Contributor

retrogtx commented Feb 4, 2025

Hi @Jynx2004, thank you for your PR!
Can you please update the relevant sections in the PR description?

The checklist and more..

@retrogtx retrogtx changed the title [CAL-5121] Remove rate workflow from free workflow templates and ask to upgrade to teams plan or above. #19063 feat: Remove rate workflow from free workflow templates and ask to upgrade to teams plan or above. Feb 4, 2025
Copy link
Contributor

@retrogtx retrogtx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you please tell me how is this related to the original issue?

<h4 className="text-emphasis mb-4 font-medium">{t("cannot_book_this_far_in_the_future")}</h4> {/* <Button onClick={nextMonthButton} color="primary" EndIcon="arrow-right" data-testid="view_next_month">

@retrogtx
Copy link
Contributor

retrogtx commented Feb 4, 2025

I suppose you added previous commits too, will get those in check with the current issue that's in focus

image

@retrogtx
Copy link
Contributor

retrogtx commented Feb 4, 2025

please approve the description with relevant information

Copy link
Member

@CarinaWolli CarinaWolli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might add ratings to the API, so we maybe want to keep it for free users. Requesting changes for nor until a decision is made. Thank you for your contribution 🙏

@Jynx2004
Copy link
Author

Jynx2004 commented Feb 4, 2025

We might add ratings to the API, so we maybe want to keep it for free users. Requesting changes for nor until a decision is made. Thank you for your contribution 🙏

Well that should be a good solution . Because right now i have provided the solution in frontend .

@Jynx2004
Copy link
Author

Jynx2004 commented Feb 4, 2025

please approve the description with relevant information

Next Time , i will make sure .

@Jynx2004
Copy link
Author

Jynx2004 commented Feb 4, 2025

Could you please tell me how is this related to the original issue?

<h4 className="text-emphasis mb-4 font-medium">{t("cannot_book_this_far_in_the_future")}</h4> {/* <Button onClick={nextMonthButton} color="primary" EndIcon="arrow-right" data-testid="view_next_month">

I think this issue has been closed before , so i will undo the changes

@Jynx2004
Copy link
Author

Jynx2004 commented Feb 4, 2025

Hi @Jynx2004, thank you for your PR! Can you please update the relevant sections in the PR description?

The checklist and more..

Yes Sure

@Jynx2004
Copy link
Author

Jynx2004 commented Feb 4, 2025

I suppose you added previous commits too, will get those in check with the current issue that's in focus

image

Sure

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Created by Linear-GitHub Sync ❗️ .env changes contains changes to env variables 🧹 Improvements Improvements to existing features. Mostly UX/UI insights area: insights, analytics Medium priority Created by Linear-GitHub Sync workflows area: workflows, automations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CAL-5121] Remove rate workflow from free workflow templates and ask to upgrade to teams plan or above.
4 participants