Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Recurring meeting creates increasing number of Zoom events #18360

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: Recurring meeting creates increasing number of Zoom events #18360

wants to merge 2 commits into from
+1 −2

Conversation

anikdhabal
Copy link
Contributor

@anikdhabal anikdhabal commented Dec 23, 2024 •
edited
Loading

@graphite-app graphite-app bot requested a review from a team December 23, 2024 19:02
@dosubot dosubot bot added app-store area: app store, apps, calendar integrations, google calendar, outlook, lark, apple calendar 🐛 bug Something isn't working labels Dec 23, 2024
@keithwillcode keithwillcode added the core area: core, team members only label Dec 23, 2024
@dosubot dosubot bot added this to the v4.9 milestone Dec 23, 2024
@vercel Vercel
Copy link

vercel bot commented Dec 23, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments
Name Status Preview Comments Updated (UTC)
cal ⬜️ Ignored (Inspect) Visit Preview Dec 23, 2024 7:03pm
calcom-web-canary ⬜️ Ignored (Inspect) Visit Preview Dec 23, 2024 7:03pm

@github-actions github-actions bot added High priority Created by Linear-GitHub Sync 📉 regressing This used to work. Now it doesn't anymore. labels Dec 23, 2024
@graphite-app Graphite App
Copy link

graphite-app bot commented Dec 23, 2024 •
edited
Loading

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (12/23/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (12/25/24)

1 label was added to this PR based on Keith Williams's automation.

anikdhabal
anikdhabal commented Dec 23, 2024
View reviewed changes
packages/app-store/zoomvideo/lib/VideoApiAdapter.ts
@@ -105,7 +105,7 @@ const ZoomVideoApiAdapter = (credential: CredentialPayload): VideoApiAdapter =>
recurringEvent,
startTime,
attendees,
}: CalendarEvent): { recurrence: ZoomRecurrence; type: 8 } | undefined => {
}: CalendarEvent): { recurrence: ZoomRecurrence } | undefined => {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Now only one Zoom event will create on each interval

alishaz-polymath
alishaz-polymath approved these changes Dec 25, 2024
View reviewed changes
Copy link
Member

@alishaz-polymath alishaz-polymath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 🚀 🚀 🚀

@github-actions GitHub Actions
Copy link
Contributor

E2E results are ready!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alishaz-polymath alishaz-polymath alishaz-polymath approved these changes

Assignees
No one assigned
Labels
app-store area: app store, apps, calendar integrations, google calendar, outlook, lark, apple calendar 🐛 bug Something isn't working core area: core, team members only High priority Created by Linear-GitHub Sync ready-for-e2e 📉 regressing This used to work. Now it doesn't anymore.
Projects
None yet
Milestone
v4.9
Development

Successfully merging this pull request may close these issues.

[CAL-4158] Recurring meeting creates increasing number of Zoom events
3 participants
@anikdhabal @alishaz-polymath @keithwillcode