-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Setting for rescheduling past bookings #18358
base: main
Are you sure you want to change the base?
feat: Setting for rescheduling past bookings #18358
Conversation
@Amit91848 is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (12/23/24)1 reviewer was added to this PR based on Keith Williams's automation. "Add community label" took an action on this PR • (12/23/24)1 label was added to this PR based on Keith Williams's automation. "Add ready-for-e2e label" took an action on this PR • (12/23/24)1 label was added to this PR based on Keith Williams's automation. |
@@ -0,0 +1,2 @@ | |||
-- AlterTable | |||
ALTER TABLE "EventType" ADD COLUMN "alllowReschedulingPastBookings" BOOLEAN NOT NULL DEFAULT false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix the file name
@@ -215,7 +215,7 @@ function BookingListItem(booking: BookingItemProps) { | |||
]; | |||
|
|||
const editBookingActions: ActionType[] = [ | |||
...(isBookingInPast | |||
...(isBookingInPast && !booking.eventType.alllowReschedulingPastBookings |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's add e2e test to verify this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left comment
What does this PR do?
Recording.2024-12-23.222711.mp4
Mandatory Tasks (DO NOT REMOVE)