Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Setting for rescheduling past bookings #18358

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

Amit91848
Copy link
Contributor

What does this PR do?

Recording.2024-12-23.222711.mp4

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

Copy link

vercel bot commented Dec 23, 2024

@Amit91848 is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Dec 23, 2024
@graphite-app graphite-app bot requested a review from a team December 23, 2024 17:00
@github-actions github-actions bot added ❗️ migrations contains migration files event-types area: event types, event-types Medium priority Created by Linear-GitHub Sync ✨ feature New feature or request labels Dec 23, 2024
@dosubot dosubot bot added the bookings area: bookings, availability, timezones, double booking label Dec 23, 2024
Copy link

graphite-app bot commented Dec 23, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (12/23/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (12/23/24)

1 label was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (12/23/24)

1 label was added to this PR based on Keith Williams's automation.

anikdhabal

This comment was marked as outdated.

@@ -0,0 +1,2 @@
-- AlterTable
ALTER TABLE "EventType" ADD COLUMN "alllowReschedulingPastBookings" BOOLEAN NOT NULL DEFAULT false;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fix the file name

@@ -215,7 +215,7 @@ function BookingListItem(booking: BookingItemProps) {
];

const editBookingActions: ActionType[] = [
...(isBookingInPast
...(isBookingInPast && !booking.eventType.alllowReschedulingPastBookings
Copy link
Contributor

@anikdhabal anikdhabal Dec 23, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add e2e test to verify this

Copy link
Contributor

@anikdhabal anikdhabal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left comment

@anikdhabal anikdhabal marked this pull request as draft December 23, 2024 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bookings area: bookings, availability, timezones, double booking community Created by Linear-GitHub Sync event-types area: event types, event-types ✨ feature New feature or request Medium priority Created by Linear-GitHub Sync ❗️ migrations contains migration files ready-for-e2e
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CAL-4948] Setting for rescheduling past bookings
2 participants