-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add cancel and reschedule reason variables in workflows #18305
base: main
Are you sure you want to change the base?
feat: add cancel and reschedule reason variables in workflows #18305
Conversation
@kart1ka is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
Graphite Automations"Add consumer team as reviewer" took an action on this PR • (12/20/24)1 reviewer was added to this PR based on Keith Williams's automation. "Add community label" took an action on this PR • (12/20/24)1 label was added to this PR based on Keith Williams's automation. "Add ready-for-e2e label" took an action on this PR • (12/23/24)1 label was added to this PR based on Keith Williams's automation. |
@kart1ka could you pls add a loom? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It would be great if we had test cases to validate this feature. Could you please add them @kart1ka 🙏 ?
Added loom in the description. |
It would be great if we have test cases for add and cancel and reschedule reason in workflows |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!!
E2E results are ready! |
What does this PR do?
Note: As I don’t have a SendGrid API key, I am logging the workflow email content in the codebase for testing purposes just before it is sent to SendGrid.
Loom for cancellation variable in workflow:
https://www.loom.com/share/ebfbcfe2c1044b87b4848cb4dc8186e1?sid=3bc96a08-db0b-4719-b339-4a5cac602f25
Loom for reschedule variable in workflow:
https://www.loom.com/share/d2581b1e354d41f6944d7ab68e95e35b?sid=447a5cea-25a9-4c54-b839-7227babf6a1b
Mandatory Tasks (DO NOT REMOVE)