Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add cancel and reschedule reason variables in workflows #18305

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

kart1ka
Copy link
Contributor

@kart1ka kart1ka commented Dec 20, 2024

What does this PR do?

Note: As I don’t have a SendGrid API key, I am logging the workflow email content in the codebase for testing purposes just before it is sent to SendGrid.

Loom for cancellation variable in workflow:
https://www.loom.com/share/ebfbcfe2c1044b87b4848cb4dc8186e1?sid=3bc96a08-db0b-4719-b339-4a5cac602f25

Loom for reschedule variable in workflow:
https://www.loom.com/share/d2581b1e354d41f6944d7ab68e95e35b?sid=447a5cea-25a9-4c54-b839-7227babf6a1b

Mandatory Tasks (DO NOT REMOVE)

  • I have self-reviewed the code (A decent size PR without self-review might be rejected).
  • I have updated the developer docs in /docs if this PR makes changes that would require a documentation change. If N/A, write N/A here and check the checkbox.
  • I confirm automated tests are in place that prove my fix is effective or that my feature works.

Copy link

vercel bot commented Dec 20, 2024

@kart1ka is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@graphite-app graphite-app bot requested a review from a team December 20, 2024 18:04
@graphite-app graphite-app bot added the community Created by Linear-GitHub Sync label Dec 20, 2024
@github-actions github-actions bot added workflows area: workflows, automations 🧹 Improvements Improvements to existing features. Mostly UX/UI labels Dec 20, 2024
@dosubot dosubot bot added the ✨ feature New feature or request label Dec 20, 2024
Copy link

graphite-app bot commented Dec 20, 2024

Graphite Automations

"Add consumer team as reviewer" took an action on this PR • (12/20/24)

1 reviewer was added to this PR based on Keith Williams's automation.

"Add community label" took an action on this PR • (12/20/24)

1 label was added to this PR based on Keith Williams's automation.

"Add ready-for-e2e label" took an action on this PR • (12/23/24)

1 label was added to this PR based on Keith Williams's automation.

@anikdhabal
Copy link
Contributor

@kart1ka could you pls add a loom?

Copy link
Contributor

@Praashh Praashh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It would be great if we had test cases to validate this feature. Could you please add them @kart1ka 🙏 ?

@kart1ka
Copy link
Contributor Author

kart1ka commented Dec 21, 2024

@kart1ka could you pls add a loom?

Added loom in the description.

@kart1ka
Copy link
Contributor Author

kart1ka commented Dec 22, 2024

It would be great if we had test cases to validate this feature. Could you please add them @kart1ka 🙏 ?

@Praashh I couldn't find any existing tests that are testing the working of variables in workflows. Do you have any particular cases you would like me to write tests for?

@Praashh
Copy link
Contributor

Praashh commented Dec 23, 2024

It would be great if we had test cases to validate this feature. Could you please add them @kart1ka 🙏 ?

@Praashh I couldn't find any existing tests that are testing the working of variables in workflows. Do you have any particular cases you would like me to write tests for?

It would be great if we have test cases for add and cancel and reschedule reason in workflows

@anikdhabal
Copy link
Contributor

Hey @Praashh @kart1ka it's fine now.

Copy link
Contributor

@Praashh Praashh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

Copy link
Contributor

E2E results are ready!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Created by Linear-GitHub Sync ✨ feature New feature or request 🧹 Improvements Improvements to existing features. Mostly UX/UI ready-for-e2e workflows area: workflows, automations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CAL-4871] Create variable for cancelation reason and reschedule reason.
3 participants