Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: layout for settings/teams #12979

Merged
merged 2 commits into from
Jan 2, 2024
Merged

Conversation

PeerRich
Copy link
Member

@PeerRich PeerRich commented Jan 2, 2024

not sure if this fixes #12947

@PeerRich PeerRich linked an issue Jan 2, 2024 that may be closed by this pull request
Copy link

vercel bot commented Jan 2, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 2, 2024 2:13pm
dev ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 2, 2024 2:13pm
5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ai ⬜️ Ignored (Inspect) Visit Preview Jan 2, 2024 2:13pm
cal ⬜️ Ignored (Inspect) Visit Preview Jan 2, 2024 2:13pm
cal-demo ⬜️ Ignored (Inspect) Visit Preview Jan 2, 2024 2:13pm
qa ⬜️ Ignored (Inspect) Visit Preview Jan 2, 2024 2:13pm
ui ⬜️ Ignored (Inspect) Visit Preview Jan 2, 2024 2:13pm

@github-actions github-actions bot added Low priority Created by Linear-GitHub Sync 🤔 can't reproduce The team was unable to reproduce this. Please provide a loom.com or birdeatsbugs.com video labels Jan 2, 2024
Copy link
Contributor

github-actions bot commented Jan 2, 2024

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

Copy link
Contributor

github-actions bot commented Jan 2, 2024

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

Twenty-six Pages Changed Size

The following pages changed size from the code in this PR compared to its base branch:

Page Size (compressed) First Load % of Budget (350 KB)
/[user]/[type] 258.96 KB 423.39 KB 120.97% (🟢 -0.25%)
/[user]/[type]/embed 258.99 KB 423.43 KB 120.98% (🟢 -0.25%)
/apps/[slug]/[...pages] 544.98 KB 709.41 KB 202.69% (🟢 -0.23%)
/availability 421.59 KB 586.03 KB 167.44% (🟢 -0.26%)
/availability/[schedule] 349.3 KB 513.74 KB 146.78% (🟢 -0.18%)
/bookings/[status] 313.28 KB 477.72 KB 136.49% (🟢 -0.19%)
/d/[link]/[slug] 258.8 KB 423.24 KB 120.92% (🟢 -0.25%)
/event-types 542.87 KB 707.31 KB 202.09% (🟢 -0.25%)
/event-types/[type] 419.43 KB 583.87 KB 166.82% (🟢 -0.21%)
/getting-started/[[...step]] 401.77 KB 566.2 KB 161.77% (🟢 -0.33%)
/org/[orgSlug]/[user]/[type] 259.2 KB 423.63 KB 121.04% (🟢 -0.25%)
/org/[orgSlug]/[user]/[type]/embed 259.22 KB 423.66 KB 121.05% (🟢 -0.26%)
/org/[orgSlug]/instant-meeting/team/[slug]/[type] 258.82 KB 423.25 KB 120.93% (🟢 -0.25%)
/org/[orgSlug]/team/[slug]/[type] 258.85 KB 423.28 KB 120.94% (🟢 -0.26%)
/settings/my-account/appearance 275.54 KB 439.97 KB 125.71% (🟢 -0.23%)
/settings/my-account/general 340.34 KB 504.78 KB 144.22% (🟢 -0.21%)
/settings/organizations/appearance 275.58 KB 440.02 KB 125.72% (🟢 -0.23%)
/settings/organizations/teams/other/[id]/appearance 264.64 KB 429.07 KB 122.59% (🟢 -0.23%)
/settings/organizations/teams/other/[id]/members 259.14 KB 423.58 KB 121.02% (🟢 -0.21%)
/settings/security/impersonation 257.32 KB 421.75 KB 120.50% (🟢 -0.22%)
/settings/security/password 266.1 KB 430.53 KB 123.01% (🟢 -0.22%)
/settings/teams/[id]/appearance 264.62 KB 429.06 KB 122.59% (🟢 -0.23%)
/settings/teams/[id]/members 377.87 KB 542.3 KB 154.94% (🟢 -0.21%)
/team/[slug]/[type] 258.81 KB 423.25 KB 120.93% (🟢 -0.25%)
/team/[slug]/[type]/embed 258.84 KB 423.28 KB 120.94% (🟢 -0.26%)
/workflows 283.79 KB 448.23 KB 128.07% (🟢 -0.22%)
Details

Only the gzipped size is provided here based on an expert tip.

First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If next/link is used, subsequent page loads would only need to download that page's bundle (the number in the "Size" column), since the global bundle has already been downloaded.

Any third party scripts you have added directly to your app using the <script> tag are not accounted for in this analysis

The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored.

@PeerRich PeerRich removed the 🤔 can't reproduce The team was unable to reproduce this. Please provide a loom.com or birdeatsbugs.com video label Jan 2, 2024
@Udit-takkar Udit-takkar merged commit 218f6a8 into main Jan 2, 2024
24 checks passed
@Udit-takkar Udit-takkar deleted the 12947-settingsteams-layout-is-wrong branch January 2, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core area: core, team members only Low priority Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

/settings/teams layout is wrong
3 participants