Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: settings/teams page wrong layout issue #12968

Closed
wants to merge 6 commits into from
Closed

fix: settings/teams page wrong layout issue #12968

wants to merge 6 commits into from

Conversation

Rksingh090
Copy link

Fixes #12947

@CLAassistant
Copy link

CLAassistant commented Dec 29, 2023 •
edited
Loading

CLA assistant check
All committers have signed the CLA.

@vercel Vercel
Copy link

vercel bot commented Dec 29, 2023

@Rksingh090 is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 29, 2023 •
edited
Loading

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

@github-actions github-actions bot added Low priority Created by Linear-GitHub Sync 🤔 can't reproduce The team was unable to reproduce this. Please provide a loom.com or birdeatsbugs.com video labels Dec 29, 2023
@Rksingh090 Rksingh090 changed the title Fix/teams page layout issue fix: settings/teams page wrong layout issue Dec 29, 2023
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 29, 2023 •
edited
Loading

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@github-actions github-actions bot added the ❗️ .env changes contains changes to env variables label Dec 29, 2023
@Rksingh090 Rksingh090 closed this Dec 29, 2023
@Rksingh090 Rksingh090 deleted the fix/teams_page_layout_issue branch December 29, 2023 20:10
@Rksingh090 Rksingh090 restored the fix/teams_page_layout_issue branch December 29, 2023 20:10
@Rksingh090 Rksingh090 reopened this Dec 29, 2023
@Rksingh090
Copy link
Author

Rksingh090 commented Dec 29, 2023 •
edited
Loading

I fixed the issue but accidently pushed the yarn.lock. Somehow i have removed yarn.lock but got other changes that i haven't touched. First time contributing. Please help.

PeerRich
PeerRich requested changes Jan 1, 2024
View reviewed changes
Copy link
Member

@PeerRich PeerRich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why do you think removing senty server webpack is fixing this issue?

@Rksingh090
Copy link
Author

I just wanted to change 1 line in apps/web/lib/app-providers.tsx. Maybe when i was trying to remove the yarn.lock at that time some wrong commands changed the files. I thing i should create a new pul request with different branch.

@Rksingh090 Rksingh090 closed this Jan 1, 2024
@Rksingh090 Rksingh090 deleted the fix/teams_page_layout_issue branch January 1, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@PeerRich PeerRich PeerRich requested changes

Assignees
No one assigned
Labels
🤔 can't reproduce The team was unable to reproduce this. Please provide a loom.com or birdeatsbugs.com video ❗️ .env changes contains changes to env variables Low priority Created by Linear-GitHub Sync
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

/settings/teams layout is wrong
3 participants
@Rksingh090 @CLAassistant @PeerRich