Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: broken height on weekly view booker #12959

Merged
merged 1 commit into from
Dec 28, 2023
Merged

fix: broken height on weekly view booker #12959

merged 1 commit into from
Dec 28, 2023

Conversation

sean-brydon
Copy link
Member

What does this PR do?

Fixes: https://threads.com/messages/3ac5f762-2e64-4651-afa9-375ad13192ae?messageID=647bdafa-fd42-46f2-a758-6e03187393e9

Before:
CleanShot 2023-12-29 at 05 00 01

After:
CleanShot 2023-12-29 at 04 59 35

Requirement/Documentation

  • If there is a requirement document, please, share it here.
  • If there is ab UI/UX design document, please, share it here.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Tests (Unit/Integration/E2E or any other test)
  • This change requires a documentation update

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my PR needs changes to the documentation
  • I haven't checked if my changes generate no new warnings
  • I haven't added tests that prove my fix is effective or that my feature works
  • I haven't checked if new and existing unit tests pass locally with my changes

Copy link

vercel bot commented Dec 28, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
ai ✅ Ready (Inspect) Visit Preview Dec 28, 2023 7:14pm
api ✅ Ready (Inspect) Visit Preview Dec 28, 2023 7:14pm
3 Ignored Deployments
Name Status Preview Updated (UTC)
cal ⬜️ Ignored (Inspect) Dec 28, 2023 7:14pm
cal-demo ⬜️ Ignored (Inspect) Dec 28, 2023 7:14pm
ui ⬜️ Ignored (Inspect) Dec 28, 2023 7:14pm

Copy link
Contributor

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

@zomars zomars added the core area: core, team members only label Dec 28, 2023
Copy link
Contributor

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

Copy link
Contributor

@emrysal emrysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Nice one

@emrysal emrysal merged commit 5de77e3 into main Dec 28, 2023
25 checks passed
@emrysal emrysal deleted the fix/weekly-view branch December 28, 2023 20:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core area: core, team members only
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants