Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: CalProvider logic to handle access and refresh tokens #12924

Closed

Conversation

Ryukemeister
Copy link
Contributor

What does this PR do?

Fixes # (issue)

Requirement/Documentation

  • If there is a requirement document, please, share it here.
  • If there is ab UI/UX design document, please, share it here.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Tests (Unit/Integration/E2E or any other test)
  • This change requires a documentation update

How should this be tested?

  • Are there environment variables that should be set?
  • What are the minimal test data to have?
  • What is expected (happy path) to have (input and output)?
  • Any other important info that could help to test that PR

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my PR needs changes to the documentation
  • I haven't checked if my changes generate no new warnings
  • I haven't added tests that prove my fix is effective or that my feature works
  • I haven't checked if new and existing unit tests pass locally with my changes

nicolls1 and others added 23 commits December 14, 2023 07:14
…12564)

* fix: allow API access to creating a team that you are a member of

* update roles allowed to create event types

* add back comment

* revert yarn.lock

---------

Co-authored-by: Omar López <[email protected]>
Co-authored-by: Peer Richelsen <[email protected]>
* chore:hsl-update-colors

* chore:hsl-update-colors

* update % color

* Fix HSL SL %

* Update SB styles

* lint

---------

Co-authored-by: Peer Richelsen <[email protected]>
* fix: type error

* chore

* Dont run future tests

* Skip more tests

* Fix 404 text

* Fix more tests

---------

Co-authored-by: Hariom <[email protected]>
* fix: 404 /event-types on login

* Set APP_ROUTER env vars to 0 whilst appdir is disabled
Co-authored-by: Hariom <[email protected]>
Co-authored-by: Keith Williams <[email protected]>
* Add metadata to bookingMinimalSelect

* add: Show link location in /bookings

* Refactor: Update variable declaration and conditional rendering in booking metadata

- Remove explicit type declaration in locationVideoCallUrl assignment
- Use conditional rendering for provider icon based on iconUrl existence

Co-authored-by: Udit Takkar <[email protected]>

* Display URL location exclusively, omitting addresses

---------

Co-authored-by: Udit Takkar <[email protected]>
Co-authored-by: Peer Richelsen <[email protected]>
…become member of the org (#12774)

* fix: Add org membership when invite link for a team in an org is generated

* Run tests sequentially till we fix emails fixture
* fix: only owners can award owner role in an organization.

* chore: improve code

---------

Co-authored-by: Udit Takkar <[email protected]>
* chore: Moved e2e suite to run on pushes to main

* Update yarn.lock

* Small cleanup

* Moved production build without database to pre-release

* Added name to script

* Added changes, lint and build dependencies
 (#12833)

* Updated the Big FIx 12773 sing-in

* FIX #12773 CSS Issue - Type Error

* Lint Error CHanges

* Debug Lint Error

* Lint Error Fix

* Changed

* Added CSS typo Error

* Added CSS typo Error - Removed Style Componet

* VS COde lint error fix

* Removing in the Button

* chore: fix login button

---------

Co-authored-by: Udit Takkar <[email protected]>
Co-authored-by: Udit Takkar <[email protected]>
… org (#12854)

* fix: Correctly prefill username in case of non-org email invite in an org

* Update test

---------

Co-authored-by: Udit Takkar <[email protected]>
* fix: join subteam as their respective organization role

* refactor code

* fix: join subteam as their respective organization role

* fix: join subteam as their respective organization role for pending members

* fix: Set subteam role to admin when updating organization role to admin

* refactor: suggested changes and fix type error

* fix: type error
Copy link

linear bot commented Dec 22, 2023

Copy link

vercel bot commented Dec 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
api ❌ Failed (Inspect) Dec 28, 2023 9:26am
dev ❌ Failed (Inspect) Dec 28, 2023 9:26am
5 Ignored Deployments
Name Status Preview Comments Updated (UTC)
ai ⬜️ Ignored (Inspect) Visit Preview Dec 28, 2023 9:26am
cal ⬜️ Ignored (Inspect) Visit Preview Dec 28, 2023 9:26am
cal-demo ⬜️ Ignored (Inspect) Visit Preview Dec 28, 2023 9:26am
qa ⬜️ Ignored (Inspect) Visit Preview Dec 28, 2023 9:26am
ui ⬜️ Ignored (Inspect) Visit Preview Dec 28, 2023 9:26am

Copy link
Contributor

github-actions bot commented Dec 22, 2023

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

@Ryukemeister Ryukemeister changed the title feat: add ConnectGoogleCalendar atom and CalProvider logic to handle access token feat: CalProvider logic to handle access and refresh tokens Dec 22, 2023
@Ryukemeister
Copy link
Contributor Author

@Ryukemeister
Copy link
Contributor Author

Closing this since everything here is included in #13006

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
❗️ .env changes contains changes to env variables Medium priority Created by Linear-GitHub Sync ❗️ migrations contains migration files
Projects
None yet
Development

Successfully merging this pull request may close these issues.