-
Notifications
You must be signed in to change notification settings - Fork 8.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fix-animations on event-types/[type] page #12900
fix: fix-animations on event-types/[type] page #12900
Conversation
@DmytroHryshyn is attempting to deploy a commit to the cal Team on Vercel. A member of the Team first needs to authorize it. |
Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link. |
📦 Next.js Bundle Analysis for @calcom/webThis analysis was generated by the Next.js Bundle Analysis action. 🤖 Thirty-seven Pages Changed SizeThe following pages changed size from the code in this PR compared to its base branch:
DetailsOnly the gzipped size is provided here based on an expert tip. First Load is the size of the global bundle plus the bundle for the individual page. If a user were to show up to your website and land on a given page, the first load size represents the amount of javascript that user would need to download. If Any third party scripts you have added directly to your app using the The "Budget %" column shows what percentage of your performance budget the First Load total takes up. For example, if your budget was 100kb, and a given page's first load size was 10kb, it would be 10% of your budget. You can also see how much this has increased or decreased compared to the base branch of your PR. If this percentage has increased by 20% or more, there will be a red status indicator applied, indicating that special attention should be given to this. If you see "+/- <0.01%" it means that there was a change in bundle size, but it is a trivial enough amount that it can be ignored. |
Updated dependencies detected. Learn more about Socket for GitHub ↗︎
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes LGTM
Would you be able to also update the other package that uses formkit auto animate so we dont have a mistmatch in versions?
What does this PR do?
Updates the version of autoAnimate lib, current version had a bug in the useAutoAnimate hook (see doc)
Adds prefetching of dynamically imported tabs. Prefetching was adding because dynamic loading of components caused broken animation when clicking tab for the first time. (We can consider disabling prefetching on mobile devices to save traffic)
Requirement/Documentation
Document
Type of change
How should this be tested?
Navigate to
/event-types/[type]
click tabs, see if animation is not broken.Screencast from 20.12.23 18:00:30.webm
Mandatory Tasks