Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: dropdown menu awkward hover state fixed #12876

Merged
merged 2 commits into from
Dec 19, 2023

Conversation

Manavpreeet
Copy link
Contributor

Fixes #12875

Screen.Recording.2023-12-19.at.7.01.23.PM.mov

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Chore (refactoring code, technical debt, workflow improvements)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Tests (Unit/Integration/E2E or any other test)
  • This change requires a documentation update

How should this be tested?

  • The awkward hover state was fixed at the root dropdown component level. So where ever dropdown component is used the desired behaviour is achieved now as in profile dropdown.

Mandatory Tasks

  • Make sure you have self-reviewed the code. A decent size PR without self-review might be rejected.

Checklist

  • I haven't read the contributing guide
  • My code doesn't follow the style guidelines of this project
  • I haven't commented my code, particularly in hard-to-understand areas
  • I haven't checked if my PR needs changes to the documentation
  • I haven't checked if my changes generate no new warnings
  • I haven't added tests that prove my fix is effective or that my feature works
  • I haven't checked if new and existing unit tests pass locally with my changes

Copy link

vercel bot commented Dec 19, 2023

@manavpreetsingh is attempting to deploy a commit to the cal Team on Vercel.

A member of the Team first needs to authorize it.

@github-actions github-actions bot added Low priority Created by Linear-GitHub Sync 🐛 bug Something isn't working 🤔 needs prioritisation labels Dec 19, 2023
Copy link
Contributor

github-actions bot commented Dec 19, 2023

Thank you for following the naming conventions! 🙏 Feel free to join our discord and post your PR link.

Copy link
Contributor

github-actions bot commented Dec 19, 2023

📦 Next.js Bundle Analysis for @calcom/web

This analysis was generated by the Next.js Bundle Analysis action. 🤖

This PR introduced no changes to the JavaScript bundle! 🙌

@CarinaWolli CarinaWolli requested a review from a team December 19, 2023 15:26
Copy link
Contributor

@Udit-takkar Udit-takkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine

Screen.Recording.2023-12-19.at.11.27.53.PM.mov

@Udit-takkar Udit-takkar enabled auto-merge (squash) December 19, 2023 17:58
@Udit-takkar Udit-takkar changed the title Fix: dropdown menu awkward hover state fixed fix: dropdown menu awkward hover state fixed Dec 19, 2023
@Udit-takkar Udit-takkar merged commit 18b994b into calcom:main Dec 19, 2023
14 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug Something isn't working Low priority Created by Linear-GitHub Sync
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dropdown menu awkward hover state
3 participants