Remove PHP 7.1+ references to keep 5.6+ compatibility. #925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @calcinai Any chance you can push this out as a .1 fix release soon? With the Xero changes, this is a blocker for us to update to the latest release which address those 😢 Thanks for all your work on this one |
|
OR you could upgrade your PHP version to one that was supported in the last 10 years? |
|
Not all of us get to inherit tech-debt free code. We can try give back to a project where we can though and help others that might also be in a similar position. |
bretto36
reviewed
Jul 25, 2024
| @@ -462,14 +462,14 @@ public function delete(Remote\Model $object) | |||
| return $object; | |||
| } | |||
|
|
|||
| public function updateAppRateLimit(int $appMinLimitRemining) | |||
| public function updateAppRateLimit($appMinLimitRemining) | |||
There was a problem hiding this comment.
You reckon you could add the phpdoc version of the prop types? Just so there is no loss in the IDE auto complete
/*
* @param int $appMinLimitRemining.
*/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes updates that break compatibility with PHP 5.6