-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed Staring Page #87
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
onClick={() => checkDelivery()} | ||
disabled={numberOfItems === 0} | ||
> | ||
Check Out |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you change this to make sure that the button has styling on the text?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
also the wording changed to place order?
@@ -65,8 +65,9 @@ export const Backtext = styled.p` | |||
export const TrashIcon = styled(Trash2)` | |||
width: 30px; | |||
height: 30px; | |||
color: black; | |||
color: navy; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
use the color json!
@@ -62,6 +63,9 @@ export default function OrderConfirmationDelivery() { | |||
<NavBar /> | |||
<CenterDiv> | |||
<PageDiv> | |||
<BackButtonDiv> | |||
<BackButton destination="./storefront" /> | |||
</BackButtonDiv> | |||
<BottomColumnDiv> | |||
<LeftColumnDiv> | |||
<BackButton destination="./storefront" /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is there two backbuttons?
<span | ||
style={{ | ||
display: 'inline-block', | ||
fontWeight: 'bold', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
don't do inline styling! I feel like we should keep in consistent
Quantity: | ||
</span> | ||
<span | ||
style={{ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same idea
@@ -116,10 +115,30 @@ export default function OrderConfirmationPickUp() { | |||
<LabelBox1> | |||
<Body1Bold>{cartItem.name}</Body1Bold> | |||
<br /> | |||
<Body2Light>Category: {cartItem.category}</Body2Light> | |||
<Body2Light style={{ marginTop: '-10px' }}> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ideally avoid inline
<div> | ||
<span | ||
style={{ | ||
display: 'inline-block', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here
What's new in this PR
Description
Fixed so that when a user navigates to the site the first page that they see is the login page and not just a blank screen with the word login on it.
Screenshots
How to review
Next steps
Relevant Links
Online sources
Related PRs
🛍 CC: @EthanAuyeung