feat: PickUp Page redesign #80
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
A couple things:
|
could you double check your styling to make sure that the margins and whatnot are fitting the screen.
|
| <TextDiv> | ||
| <Heading3Bold>Your order has been submitted</Heading3Bold> | ||
| </TextDiv> | ||
| <OutterFavoriteDiv> |
There was a problem hiding this comment.
can you change the name of this div. I think in the past, someone might've copied the favorites style but we should prob rename them
| <Body1Bold>{cartItem.name}</Body1Bold> | ||
| <Body2Light>Category: {cartItem.category}</Body2Light> | ||
| </LabelBox> | ||
| </FavoriteDiv> |
| padding-top: 10px; | ||
| width: 350px; | ||
| padding-left: 0px; | ||
| border-top: 1px black solid; |
There was a problem hiding this comment.
don't use black -> do color.black
|
|
||
| export const WhiteBackgroundDiv = styled.div` | ||
| border-radius: 8px; | ||
| background: var(--White, #fff); |
There was a problem hiding this comment.
use the color file :)
| flex-direction: column; | ||
| align-items: flex-start; | ||
| border-radius: 10px; | ||
| background: var(--White, #fff); |
| max-height: 100%; | ||
| padding: 36px 34px; | ||
| gap: 33px; | ||
| max-height: 100%; |
There was a problem hiding this comment.
why is there two max heights
| `; | ||
|
|
||
| export const DetailsHeader = styled.p` | ||
| color: var(--Navy, #1b3679); |
|
|
||
| export const DetailsHeader = styled.p` | ||
| color: var(--Navy, #1b3679); | ||
| font-family: Public Sans, sans-serif; |
There was a problem hiding this comment.
if you imported the text file then you shouldn't need this part
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new in this PR
Description
Re-designed the frontend of the pick up confirmation page according to Katy's re-designs on the Figma.
Screenshots
How to review
orderConfirmationPickUp
Next steps
N/A
Relevant Links
Online sources
N/A
Related PRs
N/A
🛍 CC: @BuyankhuuTsCAl