Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Buyankhuu/log in screen #7

Merged
merged 7 commits into from
Oct 4, 2023
Merged

Buyankhuu/log in screen #7

merged 7 commits into from
Oct 4, 2023

Conversation

BuyankhuuTsCAl
Copy link
Collaborator

@BuyankhuuTsCAl BuyankhuuTsCAl commented Oct 3, 2023

Implemented the login screen based on Katy's Figma design. [src/app/screens/loginScreen]

Description

Created Login Page:

newly created components:

-"src/app/components/InputFields.tsx" is meant for the input field where the user would be able to type in their email + password. Takes in two arguments within the props: text and placeholder. Text is used for the Header of the input field, while the placeholder is the argument used within the input component. For example, the text can be a password, and the placeholder can be *******.

  • "src/app/components/LoginForm.tsx" is meant to combine the input fields of Email address and password into one div. Renders the InputFields component.

changes to src/app/screens/loginScreen:

  • page.tsx is where the entirety of the login screen is rendered. Used LoginForm component. Calls , which applies a style to the whole page. LoginBox is the box with the border, while LoginContent is the div to keep everything together, such as the welcome sign, login form, and button.
  • styles.ts is where the styled-components are defined.
  • shantiLogo.png was added

Screenshots

Screen Shot 2023-10-02 at 8 42 28 PM

How to review

Open the webpage and navigate to http://localhost:3000/screens/loginScreen to view the implementation.

Order to review files: InputFields -> LoginForm.tsx ->page.tsx(within loginScreen)->styles.ts.

Notes: the image is not working at the moment. I attempted to render it as a component, but it did not work.

Next steps

  • getting to fix the image. right now the yellow box represents where the image would go.

Relevant Links

Online sources

https://www.figma.com/file/uEJp29FD9wTYN48ESD2Mkb/Shanti-Project?type=design&node-id=14-19&mode=design&t=ZqgCmOnkXSmgUAVE-0

Related PRs

🛍 CC: @EthanAuyeung

@vercel
Copy link

vercel bot commented Oct 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
shanti-project ✅ Ready (Inspect) Visit Preview Oct 3, 2023 10:13pm

Copy link
Collaborator

@EthanAuyeung EthanAuyeung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Perfect pr thank you for putting so much detail into the description and request.

@EthanAuyeung EthanAuyeung merged commit f7e7b40 into main Oct 4, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants