Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Casey/user pickup delivery #21

Merged
merged 13 commits into from
Nov 3, 2023
Merged

Casey/user pickup delivery #21

merged 13 commits into from
Nov 3, 2023

Conversation

caseyzlei
Copy link
Contributor

@caseyzlei caseyzlei commented Oct 26, 2023 •
edited
Loading

What's new in this PR

Description

This PR

  • Implements conditional nav to take the logged in user from checkout to either delivery or pickup depending on the value of their delivery_allowed attribute
  • Fixes all queries to pull from the profiles table instead of Users
  • Fixes types in schema.ts to match supabase
  • Adds import/resolver to eslint to help validate improper imports

Screenshots

How to review

  • Pull branch
  • Login with the credentials of an authenticated user in supabase
  • Navigate to /checkout
  • Click the checkout button and make sure you are redirected to the correct page
  • Change the delivery_allowed attribute on supabase & reload the site
  • Make sure checkout navs correctly upon change

Next steps

  • Implement user sign up flow

Relevant Links

Online sources

Related PRs

🛍 CC: @EthanAuyeung

@vercel
Copy link

vercel bot commented Oct 26, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
shanti-project ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 29, 2023 9:29pm

@kevinjcai kevinjcai self-requested a review October 26, 2023 06:34
@caseyzlei caseyzlei marked this pull request as ready for review October 29, 2023 21:16
@caseyzlei caseyzlei changed the title WIP: Casey/user pickup delivery Casey/user pickup delivery Oct 29, 2023
EthanAuyeung
EthanAuyeung reviewed Oct 31, 2023
View reviewed changes
Copy link
Collaborator

@EthanAuyeung EthanAuyeung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! Will merge in after we go over how to review pr's.

kevinjcai
kevinjcai reviewed Nov 3, 2023
View reviewed changes
Copy link
Contributor

@kevinjcai kevinjcai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@EthanAuyeung EthanAuyeung merged commit 3a66963 into main Nov 3, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kevinjcai kevinjcai kevinjcai left review comments

@EthanAuyeung EthanAuyeung EthanAuyeung left review comments

@celinechoiii celinechoiii Awaiting requested review from celinechoiii

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@caseyzlei @EthanAuyeung @kevinjcai