Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] implements the footer #74

Merged
merged 16 commits into from
May 19, 2024
Merged

[feat] implements the footer #74

merged 16 commits into from
May 19, 2024

Conversation

kevin3656
Copy link
Contributor

@kevin3656 kevin3656 commented Apr 5, 2024 •
edited by varortz
Loading

🎋 Description

🌴 What's new in this PR

  • Implemented footer
  • Added new icons, used in the footer to redirect user to IJP's social media

🌲 Screenshots

image

🌳 How to review

  • app/page.tsx holds the implementation for the footer
  • app/styles.tsx holds the styles used on footer
  • added icons to lib/icons.tsx
  • Should be reviewed all at once
  • Clicking on "ABA Website" and "IJP commission" should redirect to the corresponding websites, as should each social media icon.
  • Would like feedback on footers reaction to window resize.

🌱 Next steps

  • implementing the actual homepage will make it so the footer is at the bottom of the page

🔗 Relevant Links

ℹ️ Online sources

🪴 Related PRs

CC: @varortz

@linear Linear
Copy link

linear bot commented Apr 5, 2024

IJP-123 Implement the Footer

@varortz varortz changed the title feat: footer implementation [feat] implements the footer Apr 9, 2024
varortz
varortz reviewed Apr 9, 2024
View reviewed changes
src/app/page.tsx Outdated Show resolved Hide resolved
varortz
varortz reviewed Apr 14, 2024
View reviewed changes
src/lib/icons.tsx Outdated Show resolved Hide resolved
varortz
varortz reviewed Apr 14, 2024
View reviewed changes
src/app/page.tsx Outdated Show resolved Hide resolved
varortz
varortz reviewed Apr 14, 2024
View reviewed changes
src/app/page.tsx Outdated Show resolved Hide resolved
jinkang-0
jinkang-0 reviewed Apr 18, 2024
View reviewed changes
src/app/styles.tsx Outdated Show resolved Hide resolved
jinkang-0
jinkang-0 reviewed Apr 21, 2024
View reviewed changes
src/components/Footer/styles.tsx Outdated Show resolved Hide resolved
public/footerimage.webp Outdated Show resolved Hide resolved
@kevin3656 kevin3656 force-pushed the kevin/ijp-123-implement-the-footer branch from 0fbc91f to 0938d76 Compare April 21, 2024 22:53
ccatherinetan
ccatherinetan reviewed May 1, 2024
View reviewed changes
src/lib/icons.tsx Outdated Show resolved Hide resolved
ccatherinetan
ccatherinetan reviewed May 1, 2024
View reviewed changes
src/styles/text.tsx Outdated Show resolved Hide resolved
@kevin3656 kevin3656 force-pushed the kevin/ijp-123-implement-the-footer branch from b62cb22 to 54fe635 Compare May 9, 2024 13:53
jinkang-0
jinkang-0 reviewed May 11, 2024
View reviewed changes
Copy link
Contributor

@jinkang-0 jinkang-0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good kevin!! just left some nits, but otherwise should be good to go after we address the prettier complaints!

src/components/Footer/index.tsx Outdated Show resolved Hide resolved
@varortz varortz self-requested a review May 15, 2024 22:59
@varortz varortz force-pushed the kevin/ijp-123-implement-the-footer branch from 3b3b5c5 to 681ebcd Compare May 15, 2024 23:17
jinkang-0
jinkang-0 reviewed May 15, 2024
View reviewed changes
src/components/Footer/index.tsx Outdated Show resolved Hide resolved
src/components/Footer/index.tsx Outdated Show resolved Hide resolved
src/components/Footer/index.tsx Show resolved Hide resolved
src/components/Footer/index.tsx Outdated Show resolved Hide resolved
jinkang-0
jinkang-0 reviewed May 18, 2024
View reviewed changes
src/components/Footer/index.tsx Outdated Show resolved Hide resolved
src/components/Footer/index.tsx Outdated Show resolved Hide resolved
src/components/Footer/index.tsx Outdated Show resolved Hide resolved
src/components/Footer/index.tsx Outdated Show resolved Hide resolved
jinkang-0
jinkang-0 approved these changes May 19, 2024
View reviewed changes
Copy link
Contributor

@jinkang-0 jinkang-0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@varortz varortz merged commit 3bdad20 into main May 19, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@varortz varortz varortz approved these changes

@ccatherinetan ccatherinetan ccatherinetan left review comments

@jinkang-0 jinkang-0 jinkang-0 approved these changes

@pragyakallanagoudar pragyakallanagoudar Awaiting requested review from pragyakallanagoudar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kevin3656 @ccatherinetan @jinkang-0 @varortz