-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feat] implements the navbar #65
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the nav bar looks rlly good! I couldn't fully review this because the cases page is erroring for me, so i couldn't check the functionality of clicking on cases/language support etc on the navbar... is anyone else having the same problem? (the font also doesn't show up for me? maybe that's a me thing)
i caught 1 place where the navbar component was erroneously added (in (auth)/email-verified
). overall, good job! i'll check back in once we figure out the error w/ the cases page T^T
To reduce redundancy and keep merge errors at a minimum, I would recommend placing the This may sound like lunacy, but hear me out. Since the
This may bring a significant change to what you have right now, but I would highly encourage adopting this paradigm as it is used commonly in practice, due to it's ability to take advantage of the And also make our lives easier. Merge conflicts bad. |
bd2588e
to
cb0c41a
Compare
15b5a18
to
7032e96
Compare
looks good kevin! should be good after addressing some minor nits and prettier complaints! |
…lines from NavBar/Styles
cf2d903
to
0a10848
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
NAVBAR LOOKS AMAZING!!! Thank you Kevin for working on this throughout semester, you killed it :)
🎋 Description
🌴 What's new in this PR
🌲 Screenshots
🌳 How to review
From the homepage you should be able to navigate across pages using nav bar, when logged in nav bar should change to show profile instead of log in/sign up buttons
can check implementation on src/components/NavBar
🌱 Next steps
🔗 Relevant Links
ℹ️ Online sources
https://www.youtube.com/watch?v=SLfhMt5OUPI
🪴 Related PRs
CC: @varortz