Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[saved] Saved stories page #73

Merged
merged 21 commits into from
Apr 21, 2024
Merged

[saved] Saved stories page #73

merged 21 commits into from
Apr 21, 2024

Conversation

kylezryr
Copy link
Contributor

@kylezryr kylezryr commented Mar 21, 2024

What's new in this PR

  • Added the library page with a LibraryHeader component displaying username and settings button
  • Added toggle bar between favorites list and reading list to display story preview cards of user's favorite and reading list

Relevant Links

Notion Sprint Task

https://www.notion.so/calblueprint/saved-Saved-stories-page-33f5d4e671204e7eb635d445714c2e63

Online sources

Related PRs

How to review

  • Log in with an account that already has an existing favorite and reading list, or manually add stories to the account's lists
  • Go to library page and check that stories are displayed correctly, and clicking on story cards navigates to that story
  • Check that toggling between reading and favorites list does so

Next steps

Tests Performed, Edge Cases

Screenshots

RPReplay_Final1710918614.MP4

CC: @adityapawar1

@kylezryr kylezryr marked this pull request as ready for review March 21, 2024 20:32
@adityapawar1
Copy link
Collaborator

I'll review this more in depth when we have the functionality for adding to reading list/favorites so its easier to test

Copy link
Collaborator

@adityapawar1 adityapawar1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

YAY DONE

@adityapawar1 adityapawar1 merged commit 14dbd0d into main Apr 21, 2024
1 check passed
@adityapawar1 adityapawar1 deleted the kyle/savedStoriesPage branch April 21, 2024 23:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants