Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[home] Update content card #63

Merged
merged 22 commits into from
Apr 4, 2024
Merged

[home] Update content card #63

merged 22 commits into from
Apr 4, 2024

Conversation

Marcoss28
Copy link
Collaborator

What's new in this PR

Content Card is changed to match the updated look on Figma. Reactions are displayed, button to add to story list is created, author profile images show at the top right of the story image, and some styling changes.

Relevant Links

N/A

Notion Sprint Task

https://www.notion.so/calblueprint/home-Update-content-card-ab9462e8a2f24b5aa9719de081f2c81b

Online sources

N/A

Related PRs

N/A

How to review

Run the application and scroll down on the Home Screen to view "Recommended For You" and "New Stories". Here all the stories under these categories will be displayed using the updated Content Card. Clicking the icon to add to story list should only load a message in the console for each story.

Next steps

  • Waiting for NPO to approve reactions/emojis to add to ContentCard
  • Get the author profile image and co-author data
  • Button to add to story lists needs implementation

Tests Performed, Edge Cases

N/A

Screenshots

IMG_1548

CC: @adityapawar1

@adityapawar1 adityapawar1 changed the title Marcos/update content card [home] Update content card Mar 10, 2024
Copy link
Collaborator

@adityapawar1 adityapawar1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

really really good styling (the reactions on the bottom right look amazing!), couple of small style nits

src/components/ContentCard/ContentCard.tsx Outdated Show resolved Hide resolved
src/components/ContentCard/ContentCard.tsx Outdated Show resolved Hide resolved
src/components/ContentCard/ContentCard.tsx Outdated Show resolved Hide resolved
src/components/ContentCard/ContentCard.tsx Outdated Show resolved Hide resolved
src/app/(tabs)/home/styles.ts Outdated Show resolved Hide resolved
src/app/(tabs)/home/styles.ts Outdated Show resolved Hide resolved
Copy link
Collaborator

@adityapawar1 adityapawar1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks perfect!

@adityapawar1 adityapawar1 merged commit 3c28469 into main Apr 4, 2024
2 checks passed
@adityapawar1 adityapawar1 deleted the marcos/update-content-card branch June 13, 2024 23:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants