-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[home] Update content card #63
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adityapawar1
requested changes
Mar 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
really really good styling (the reactions on the bottom right look amazing!), couple of small style nits
adityapawar1
approved these changes
Apr 4, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks perfect!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new in this PR
Content Card is changed to match the updated look on Figma. Reactions are displayed, button to add to story list is created, author profile images show at the top right of the story image, and some styling changes.
Relevant Links
N/A
Notion Sprint Task
https://www.notion.so/calblueprint/home-Update-content-card-ab9462e8a2f24b5aa9719de081f2c81b
Online sources
N/A
Related PRs
N/A
How to review
Run the application and scroll down on the Home Screen to view "Recommended For You" and "New Stories". Here all the stories under these categories will be displayed using the updated Content Card. Clicking the icon to add to story list should only load a message in the console for each story.
Next steps
Tests Performed, Edge Cases
N/A
Screenshots
CC: @adityapawar1