Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[search] Implement genre screen #59

Merged
merged 30 commits into from
Apr 7, 2024
Merged

[search] Implement genre screen #59

merged 30 commits into from
Apr 7, 2024

Conversation

emilysunaryo
Copy link
Contributor

@emilysunaryo emilysunaryo commented Mar 1, 2024

What's new in this PR

In this PR, I implemented the logic for the Genre and Subgenre Screen. This PR has the following features:

  • Horizontal Scroll Bar of Subgenres: Each string in the scroll is a pressable that will filter through all of query outputs of the parent genre to match those that fall under that subgenre. Loading screen implemented as well when user rerenders page or switches subgenres. If there are no stories associated with that subgenre in our database, our app will return "There are no stories under this Genre or Subgenre"
  • created new component for genre story previews called genre story preview card: card displays dynamically the # of tags associated with each story, top two tags are first and second value in genre_medium array
  • created styling for drop down that should be dynamic when displaying tone and topics of all the genres and subgenres that are rendered

Relevant Links

Notion Sprint Task

https://www.notion.so/calblueprint/search-Implement-genre-screen-6d6d893cc3a4420cbb1984b6b59a5a4b

Online sources

Related PRs

Genre Card Component implementation on the Search Page is directly related to this sprint

How to review

Navigate to search in nav bar, scroll through genres and subgenres. Clicking "See All" will render all the stories under that genre. Clicking a subgenre will render only stories associated with that subgenre. Note that if there is no author, the story route when clicking on each card will generate an error saying that the author string cannot be empty. Click on story to navigate to each story

Next steps

  • figure out tone and topic drop down logic and change styling to multiselect checkboxes
  • stories are rendering very slow, figure out a way to cache or figure out global state management/Authcontext??
  • are we or are we not including subheadings for each subgenre? or genre? in the designs they were included and placeholders are shown in screenrecording

Tests Performed, Edge Cases

Screenshots

Screen.Recording.2024-03-10.at.12.18.11.PM.mov

CC: @adityapawar1

@emilysunaryo emilysunaryo self-assigned this Mar 1, 2024
@adityapawar1 adityapawar1 changed the title Emily/genre screen [search] Implement genre screen Mar 3, 2024
@adityapawar1 adityapawar1 merged commit 507523a into main Apr 7, 2024
2 checks passed
@adityapawar1 adityapawar1 deleted the emily/genreScreen branch April 7, 2024 06:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants