-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[search] Implement genre screen #59
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…down selection logic
…te-now into emily/genreScreen
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new in this PR
In this PR, I implemented the logic for the Genre and Subgenre Screen. This PR has the following features:
Relevant Links
Notion Sprint Task
https://www.notion.so/calblueprint/search-Implement-genre-screen-6d6d893cc3a4420cbb1984b6b59a5a4b
Online sources
Related PRs
Genre Card Component implementation on the Search Page is directly related to this sprint
How to review
Navigate to search in nav bar, scroll through genres and subgenres. Clicking "See All" will render all the stories under that genre. Clicking a subgenre will render only stories associated with that subgenre. Note that if there is no author, the story route when clicking on each card will generate an error saying that the author string cannot be empty. Click on story to navigate to each story
Next steps
Tests Performed, Edge Cases
Screenshots
Screen.Recording.2024-03-10.at.12.18.11.PM.mov
CC: @adityapawar1