-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[nav] Refactor auth to follow design user flows #21
Conversation
Some weird things I wasn't to sure about:
|
One small thing, try to be a little more descriptive with your PR name as |
Great callouts! We'll talk with Brenda during work session about whether a number/code entry or automatic redirect trigger makes most sense and make a decision there. We can add this to your next sprint task. I think the changing email issue should resolve itself because we'll be changing the flow of the screens. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job reworking this flow! See my comments for some small changes as well as notes about what you'll be iterating upon next
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work!
What's new in this PR
Make the auth flow follow the Figma
Relevant Links
Notion Sprint Task
https://www.notion.so/calblueprint/nav-Refactor-auth-to-follow-design-user-flows-c792823f07484bd9a251a577a2668cb2?pvs=4
Online sources
Related PRs
How to review
You can create a temporary email here if you already have an account on your personal email.
Next steps
Tests Performed, Edge Cases
Full sign-up with a new account
Screenshots
RPReplay_Final1697504961.MP4
CC: @akshaynthakur
CC: @brendovuong