Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nav] Refactor auth to follow design user flows #21

Merged
merged 9 commits into from
Oct 19, 2023

Conversation

adityapawar1
Copy link
Collaborator

What's new in this PR

Make the auth flow follow the Figma

Relevant Links

Notion Sprint Task

https://www.notion.so/calblueprint/nav-Refactor-auth-to-follow-design-user-flows-c792823f07484bd9a251a577a2668cb2?pvs=4

Online sources

Related PRs

How to review

You can create a temporary email here if you already have an account on your personal email.

Next steps

Tests Performed, Edge Cases

Full sign-up with a new account

Screenshots

RPReplay_Final1697504961.MP4

CC: @akshaynthakur
CC: @brendovuong

@adityapawar1
Copy link
Collaborator Author

adityapawar1 commented Oct 17, 2023

Some weird things I wasn't to sure about:

  • The sign up screen gets converted into the login screen (the button text and onPress change) after email verification
    • I couldn't find a way to sign up the user based on a callback of them verifying their email, so i just had them click log in when they're ready, but i think this could be worked on. Maybe we can use the redirect url, use the verify email with the sequence of numbers they send to your email, or a supabase trigger which might be able to trigger a callback on the app.
    • if the user changes their email after clicking sign up then the button will still say "log in" instead of "sign up" and would have to reload the page (go to login page and then back to sign up) to fix it.
  • The onboarding screen says "Skip for now" even after updating details which should be an easy fix, but I'm mostly concerned about the above thing

@akshaynthakur akshaynthakur self-requested a review October 17, 2023 23:30
@akshaynthakur
Copy link
Collaborator

One small thing, try to be a little more descriptive with your PR name as [auth] Auth flow is a little vague. You can always use the name of the sprint task from Notion, so in this case [nav] Refactor auth to follow design user flows.

@akshaynthakur
Copy link
Collaborator

Some weird things I wasn't to sure about:

  • The sign up screen gets converted into the login screen (the button text and onPress change) after email verification

    • I couldn't find a way to sign up the user based on a callback of them verifying their email, so i just had them click log in when they're ready, but i think this could be worked on. Maybe we can use the redirect url, use the verify email with the sequence of numbers they send to your email, or a supabase trigger which might be able to trigger a callback on the app.
    • if the user changes their email after clicking sign up then the button will still say "log in" instead of "sign up" and would have to reload the page (go to login page and then back to sign up) to fix it.
  • The onboarding screen says "Skip for now" even after updating details which should be an easy fix, but I'm mostly concerned about the above thing

Great callouts! We'll talk with Brenda during work session about whether a number/code entry or automatic redirect trigger makes most sense and make a decision there. We can add this to your next sprint task. I think the changing email issue should resolve itself because we'll be changing the flow of the screens.

Copy link
Collaborator

@akshaynthakur akshaynthakur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job reworking this flow! See my comments for some small changes as well as notes about what you'll be iterating upon next

src/app/auth/onboarding.tsx Outdated Show resolved Hide resolved
src/app/auth/login.tsx Outdated Show resolved Hide resolved
src/app/auth/login.tsx Outdated Show resolved Hide resolved
src/app/auth/onboarding.tsx Outdated Show resolved Hide resolved
src/app/auth/signup.tsx Outdated Show resolved Hide resolved
src/app/auth/signup.tsx Outdated Show resolved Hide resolved
src/app/settings.tsx Outdated Show resolved Hide resolved
@adityapawar1 adityapawar1 changed the title [auth] Auth flow [nav] Refactor auth to follow design user flows Oct 18, 2023
Copy link
Collaborator

@akshaynthakur akshaynthakur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work!

@akshaynthakur akshaynthakur merged commit ef3803e into main Oct 19, 2023
2 checks passed
@akshaynthakur akshaynthakur deleted the adi/refactor-auth-flow branch December 1, 2023 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants