Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nav] Implement expo routing and add global styles #15

Merged
merged 10 commits into from
Oct 3, 2023

Conversation

akshaynthakur
Copy link
Collaborator

What's new in this PR

  • Refactor nav using expo routing instead of react nav
  • Add blanks screens in auth flow (signup, onboarding)
  • Add global styles sheet with temporary styles

Relevant Links

Notion Sprint Task

Online sources

SUPER helpful video (better than written docs imo): https://www.youtube.com/watch?v=4-shpLyYBLc

Related PRs

How to review

  • Click all buttons and bottom tabs, ensure that routes are set properly and pages render

Next steps

  • Screen-specific styles: adding one styles sheet per screen inside of a folder seems tedious and complicates an already complex file structure
  • Need to prevent navigating back to prior screen in certain cases, eg. going back to auth/login once on the home page. Tried using router.replace() but induced weird behavior because didn't fully clear the stack -> could still go back to the -2 page on the stack

Tests Performed, Edge Cases

  • Tested on both android and ios to make sure SafeAreaView working properly

Screenshots

CC: @akshaynthakur

@akshaynthakur akshaynthakur merged commit 033141e into main Oct 3, 2023
2 checks passed
@akshaynthakur akshaynthakur deleted the akshay/expo-nav branch October 7, 2023 19:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants