[nav] Basic bottom nav implementation #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akshaynthakur
approved these changes
Oct 2, 2023
|
LGTM!!! |
akshaynthakur
changed the title
akshaynthakur
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new in this PR
Added Material Bottom Navigation Bar package from React Native and added basic routing functionality as well as a icon changes. In the process of adding a separate icons.tsx file to be able to have cleaner code although this is not fully implemented and the icons are hard coded currently
Relevant Links
Notion Sprint Task
https://www.notion.so/calblueprint/b885547588f4406bb7f6f8153be99bb9?v=6572442cb5c644a9bd1c298d53a85eec&p=5b85a042022c4bdbbd0199001ff28f13&pm=s
Online sources
Related PRs
How to review
Next steps
the icons.tsx file under assets is still something that I need to fully implement so we can start importing an Icon component rather than hard coding the icons directly. I also need to add styling for the bottom nav bar as well. (figuring out how to get rid of the purple hue )
Tests Performed, Edge Cases
Screenshots
CC: @akshaynthakur