Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[toast] Implement toast component #11

Merged
merged 6 commits into from
Oct 3, 2023
Merged

[toast] Implement toast component #11

merged 6 commits into from
Oct 3, 2023

Conversation

InayaY3
Copy link
Collaborator

@InayaY3 InayaY3 commented Sep 30, 2023

What's new in this PR

Added toast notifications to ToastScreen.

Relevant Links

Notion Sprint Task

https://www.notion.so/calblueprint/toast-Implement-toast-component-8fc61ce4784545658179fdd2322660bd

Online sources

Related PRs

How to review

really only ToastScreen.tsx, navigate to ToastScreen from home page to test

Next steps

still needs styling (currently in-line), any necessary inputs, etc.

Tests Performed, Edge Cases

pressing button, nothing else for the time being?

Screenshots

toast

CC: @akshaynthakur

@akshaynthakur akshaynthakur self-requested a review October 3, 2023 00:04
Copy link
Collaborator

@akshaynthakur akshaynthakur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work! LGTM

src/screens/ToastScreen.tsx Outdated Show resolved Hide resolved
src/screens/ToastScreen.tsx Outdated Show resolved Hide resolved
@akshaynthakur akshaynthakur merged commit 82a0973 into main Oct 3, 2023
2 checks passed
@akshaynthakur akshaynthakur deleted the inaya/toast-notif branch October 3, 2023 00:23
akshaynthakur pushed a commit that referenced this pull request Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants