[auth] Implement email account creation #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akshaynthakur
requested changes
Sep 30, 2023
sauhardjain
reviewed
Oct 3, 2023
There was a problem hiding this comment.
Really great work @adityapawar1! Appreciate the code comments, use of components, and generally good conventions. Left a few nits here and there but no major changes required.
I'd recommend adding a loading state for user feedback as one of the next steps.
|
@akshaynthakur could you also check the date thing on android? i tried downloading a simulator but i couldnt get it to work |
akshaynthakur
approved these changes
Oct 7, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new in this PR
Added email sign-up and sign-in.
Added a page to allow users to edit their user data.
Relevant Links
https://supabase.com/docs/guides/getting-started/tutorials/with-expo-react-native?auth-store=async-storage#building-the-app
Notion Sprint Task
https://www.notion.so/calblueprint/auth-Implement-email-account-creation-5432fa5d56d54dcda906646ed449d9e7?pvs=4
Online sources
Related PRs
How to review
Sign up and verify email (the verify email link will redirect to a localhost site which will say it can't find the page, but before the redirect supabase verifies the email so don't worry about the localhost not found thing)
Use the input fields to update values and check supabase to see if the changes are reflected in the profiles table.
Next steps
Tests Performed, Edge Cases
Sign up and sign in, updating all fields in the database.
Screenshots
CC: @akshaynthakur