Refactor

calblueprint · Apr 18, 2024 · 5314e98 · 5314e98
1 parent ce4d017
commit 5314e98
Show file tree

Hide file tree

Showing 2 changed files with 24 additions and 19 deletions.
diff --git a/src/components/ContentCard/ContentCard.tsx b/src/components/ContentCard/ContentCard.tsx
@@ -43,13 +43,6 @@ function ContentCard({
   const [storyIsSaved, setStoryIsSaved] = useState(false);
   const { channels, initializeChannel, publish } = usePubSub();
 
-  const savedStoryImageComponent = useMemo(() => {
-    return <Image style={{ width: 30, height: 30 }} source={savedStoryImage} />;
-  }, []);
-  const saveStoryImageComponent = useMemo(() => {
-    return <Image style={{ width: 30, height: 30 }} source={saveStoryImage} />;
-  }, []);
-
   useEffect(() => {
     isStoryInReadingList(storyId, user?.id).then(storyInReadingList => {
       setStoryIsSaved(storyInReadingList);
@@ -121,9 +114,17 @@ function ContentCard({
               </View>
             </View>
             <TouchableOpacity onPress={() => saveStory(!storyIsSaved)}>
-              {storyIsSaved
-                ? savedStoryImageComponent
-                : saveStoryImageComponent}
+              {storyIsSaved ? (
+                <Image
+                  style={{ width: 30, height: 30 }}
+                  source={savedStoryImage}
+                />
+              ) : (
+                <Image
+                  style={{ width: 30, height: 30 }}
+                  source={saveStoryImage}
+                />
+              )}
             </TouchableOpacity>
           </View>
         </View>

diff --git a/src/components/PreviewCard/PreviewCard.tsx b/src/components/PreviewCard/PreviewCard.tsx
@@ -52,13 +52,6 @@ function PreviewCard({
   const [storyIsSaved, setStoryIsSaved] = useState(false);
   const { channels, initializeChannel, publish } = usePubSub();
 
-  const savedStoryImageComponent = useMemo(() => {
-    return <Image style={{ width: 30, height: 30 }} source={savedStoryImage} />;
-  }, []);
-  const saveStoryImageComponent = useMemo(() => {
-    return <Image style={{ width: 30, height: 30 }} source={saveStoryImage} />;
-  }, []);
-
   useEffect(() => {
     isStoryInReadingList(storyId, user?.id).then(storyInReadingList => {
       setStoryIsSaved(storyInReadingList);
@@ -81,7 +74,8 @@ function PreviewCard({
 
   const saveStory = async (saved: boolean) => {
     setStoryIsSaved(saved);
-    publish(storyId, saved);
+    publish(storyId, saved); // update other cards with this story
+
     if (saved) {
       await addUserStoryToReadingList(user?.id, storyId);
     } else {
@@ -97,7 +91,17 @@ function PreviewCard({
             {title}
           </Text>
           <TouchableOpacity onPress={() => saveStory(!storyIsSaved)}>
-            {storyIsSaved ? savedStoryImageComponent : saveStoryImageComponent}
+            {storyIsSaved ? (
+              <Image
+                style={{ width: 30, height: 30 }}
+                source={savedStoryImage}
+              />
+            ) : (
+              <Image
+                style={{ width: 30, height: 30 }}
+                source={saveStoryImage}
+              />
+            )}
           </TouchableOpacity>
         </View>
         <View style={styles.body}>