Fola/upload house list #29
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to fola/uploadHouseList
…to fola/uploadHouseList
…to fola/uploadHouseList
…lueprint/bsc-web-app into fola/uploadHouseList
…lueprint/bsc-web-app into fola/uploadHouseList
…eed to add new function from apislice
…lueprint/bsc-web-app into fola/uploadHouseList
…to fola/uploadHouseList
…to fola/uploadHouseList
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
gregoriiaaa
requested changes
Apr 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new in this PR
Description
This PR involved the the upload house list flow. A user is able to upload a CSV file containing members from a singular house with the relevant fields, and see which members will be added or removed from the house.
Screenshots
How to review
There is currently only one file to really look at in this PR, and that's the uploadHouseList.tsx file. I had to change a few lines in the Authorized Users API Slice as well. I would like for whoever is testing this flow at to try to catch bugs by uploading various CSV files that vary in length, with wrong fields, blanks, etc. I would also like for the back buttons to be tested, as they were a bit buggy in the beginning.
Next steps
Right now this flow is hardcoding in the houseID as 'EUC'. When the authUser is up and running it should be changed to the house of the manager that is logged in. Also I am unsure how this flow should work if it's the supervisor that is logged in. Lastly, I did not do the uploadHouseListBtn yet, I just add a button component at the top of this file.
Relevant Links
Online sources
Related PRs
CC: @gregoriiaaa