-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Stevenh/availability #17
Open
stevenhuang010
wants to merge
12
commits into
main
Choose a base branch
from
stevenh/availability
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…to stevenh/availability merge main
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's new in this PR
Description
Filled in the functions in availabilityHelper.ts
const createListOfUsersForShift = (shiftObject: Shift, entityState: EntityState, days: string[])
const filterUsersByAvailability = (shiftObject: Shift, days: string[], entityState: EntityState)
const filterUsersByEligibility = (ids: EntityId[], entityState: EntityState, creditHours: number, shiftID: string)
const sortUsersByNeededHoursAndPreference = (ids: EntityId[], entityState: EntityState, shiftObject: Shift)
// if (!entity.timeWindowDisplay) {
// entity.timeWindowDisplay =
// formatMilitaryTime(entity.timeWindow.startTime) +
// ' - ' +
// formatMilitaryTime(entity.timeWindow.endTime)
// }
Screenshots
How to review
ShiftAssignmentHelper.tsx in the testing folder can be imported and put into any rendered component. inspect the console.log to see the outputted list.
check the shift named danashi
Next steps
stuff found: make sure firebase availabilities day (monday) is lowercase, shift times must be valid (end time and start time must have enough time to complete the shift-MUST BE ENFORCED IN THE SHIFT CREATION CARD)
// TODO: DOESN'T WORK IF SOMEONE IS ALREADY ASSIGNED DURING THEIR AVAILABILITY PERIOD TO A DIFFERENT SHIFT
Relevant Links
Online sources
Related PRs
CC: @gregoriiaaa