[feat] fixed auth context + sessionDemo #23
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
celinechoiii
reviewed
Nov 3, 2024
| }) { | ||
| const [session, setSession] = useState<Session | null>(null); | ||
|
|
||
| /* useEffect(() => { |
There was a problem hiding this comment.
can you delete the comments?
| setMessage('Login successful!'); | ||
| setIsError(false); | ||
| setTimeout(() => { | ||
| router.push('/sessionDemo'); |
There was a problem hiding this comment.
can you push onboarding/general to the router instead of the sessionDemo?
There was a problem hiding this comment.
thanks for the including this file for testing! can you unadd it so that i can merge it to main?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🍞 What's new in this PR
🥐 Description
Implemented auth context that saves login / session state and allows for sign in / sign out functionality. Currently, after login or signup, the new code will route to a dummy sessionDemo page that displays which user is currently logged in and provides a button for current user to log out with. I write to the console logs every time a new session is created which could aid in debugging / validating, but I believe I fixed the error of improperly saving the login state we discussed during worksession.
🥖 Screenshots
🥪 How to review
So the authContextProvider which contains the core functionality of the auth context is located in utils/authContextProvider.tsx
Also made adjustments to app/layout.tsx, app/auth/signin/page.tsx, app/auth/signup/page.tsx, and created a new app/auth/sessionDemo/page.tsx to illustrate that the session management works.
🥧 Next steps
🥞 Relevant links
🥨 Online sources
https://www.youtube.com/watch?v=r7SAlIlMs1k
https://github.com/calblueprint/girls-write-now/pull/17/files
🥯 Related PRs
CC: @celinechoiii @me-liu