[feat] Make Projects Listing Modal #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
itsliterallymonique
requested changes
Nov 13, 2024
There was a problem hiding this comment.
Looks good Justin! Just make the small changes I suggested.
Some things that we will address in the future (since it will require more discussions with the team):
- We will discuss design for the overflowing text.
- In the next two weeks, we will also need to fix the individual project modal closing --> redirecting direct to the all projects modal. I agree, how it currently operates is not how we want it to.
app/page.tsx
Outdated
| @@ -21,6 +22,7 @@ export default function Home() { | |||
| <main style={mainStyles}> | |||
| {error ? <div style={errorStyles}>{error}</div> : null} | |||
| {projects ? <MapViewScreen projects={projects} /> : null} | |||
| <AllProjectsModal projects={projects} /> | |||
There was a problem hiding this comment.
can you move AllProjectsModal to the MapViewScreen?
| @@ -162,16 +162,16 @@ export default function ProjectItem({ project_id }: { project_id: number }) { | |||
| </Heading2> | |||
There was a problem hiding this comment.
note: we will need to find a solution + fix when the text overflows
| @@ -0,0 +1,39 @@ | |||
| 'use client'; | |||
There was a problem hiding this comment.
Rename AllProjectsModal to ProjectsListingModal because when we filter or search, it will not show all the projects.
itsliterallymonique
approved these changes
Nov 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rebasing
What's new in this PR
Description
Screenshots
Screen.Recording.2024-11-12.at.20.16.11.mov
How to review
Next steps
Screen.Recording.2024-11-12.at.20.19.16.mov
Relevant links
Online sources
Related PRs
CC: @itsliterallymonique