Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New NTD mart table dim_annual_funding_sources #3495

Merged
merged 1 commit into from
Oct 9, 2024
Merged

Conversation

erikamov
Copy link
Contributor

@erikamov erikamov commented Oct 9, 2024

Description

This new model dim_annual_funding_sources details federal, state, and local funding sources for each applicable agency reporting to the NTD in Report Year 2022.

[#3405]

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

How has this been tested?

Tested locally using command: poetry run dbt run --select "models/mart/ntd/dim_annual_funding_sources.sql"
Model was generated on staging: cal-itp-data-infra-staging.erika_mart_ntd.dim_annual_funding_sources

Post-merge follow-ups

  • No action required
  • Actions required (specified below)

Confirm the creation of mart_ntd.dim_annual_funding_sources on cal-itp-data-infra after the next transform_warehouse runs.

@erikamov erikamov added the data-pipeline-ingestion-and-modeling Ingesting, parsing and modeling data. Evan Siroky is product owner. label Oct 9, 2024
@erikamov erikamov self-assigned this Oct 9, 2024
Copy link

github-actions bot commented Oct 9, 2024

Warehouse report 📦

Checks/potential follow-ups

Checks indicate the following action items may be necessary.

  • For new models, do they all have a surrogate primary key that is tested to be not-null and unique?

New models 🌱

calitp_warehouse.mart.ntd.dim_annual_funding_sources

DAG

Legend (in order of precedence)

Resource type Indicator Resolution
Large table-materialized model Orange Make the model incremental
Large model without partitioning or clustering Orange Add partitioning and/or clustering
View with more than one child Yellow Materialize as a table or incremental
Incremental Light green
Table Green
View White

Copy link
Member

@tiffanychu90 tiffanychu90 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can the table be renamed to dim_annual_agency_funding_source?
Thoughts on skipping the ntd portion since this is within mart_ntd already? Since this is one of the first tables, probably the convention can somewhat follow [dim/fct]_[time grain: annual/monthly]_[grain: agency, agency-mode]_[some other descriptor]?

@erikamov
Copy link
Contributor Author

erikamov commented Oct 9, 2024

Makes totally sense! Will rename it .

Can the table be renamed to dim_annual_agency_funding_source? Thoughts on skipping the ntd portion since this is within mart_ntd already? Since this is one of the first tables, probably the convention can somewhat follow [dim/fct]_[time grain: annual/monthly]_[grain: agency, agency-mode]_[some other descriptor]?

@erikamov erikamov changed the title New NTD mart table dim_annual_ntd_funding_source New NTD mart table dim_annual_funding_source Oct 9, 2024
@erikamov erikamov changed the title New NTD mart table dim_annual_funding_source New NTD mart table dim_annual_funding_sources Oct 9, 2024
…l records from federal, state, and local funding source tables.

[#3405]
@erikamov erikamov merged commit 08079dc into main Oct 9, 2024
4 checks passed
@erikamov erikamov deleted the 3405-new-ntd-tables branch October 9, 2024 23:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data-pipeline-ingestion-and-modeling Ingesting, parsing and modeling data. Evan Siroky is product owner.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants