Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): only deploy maps app previews on relevant pull requests #3454

Merged
merged 1 commit into from
Sep 13, 2024

Conversation

themightychris
Copy link
Contributor

@themightychris themightychris commented Sep 13, 2024

Description

I noticed while working on #3452 that rebasing any branch would cause this workflow to run and then deploy to a netlify preview site with the PR # missing. The issue was that the branches event runs on any branch and then the deploy preview event is only filtered to the branch not being main rather than the event being a pull request. Since that step makes use of the PR number, it doesn't make sense for it to ever run on a non-PR event as the PR number will be blank. These updates bring the triggers in line with other workflows

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation

How has this been tested?

This PR should trigger the workflow to run since it includes a change to the workflow script which is now included in the triggers.

Post-merge follow-ups

  • When this PR is merged it should to a prod deploy (with no changes to the actual application, just the workflow)
  • verify prod maps still work
  • When I rebase a Dependabot PR again this workflow should not run

Copy link

@themightychris themightychris merged commit 1202708 into main Sep 13, 2024
2 checks passed
@themightychris themightychris deleted the fix/erroneous-maps-app-deploys branch September 13, 2024 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants