Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Offboarding - clean up email references #3379

Merged
merged 3 commits into from
Jun 24, 2024
Merged

Offboarding - clean up email references #3379

merged 3 commits into from
Jun 24, 2024

Conversation

tiffanychu90
Copy link
Member

Description

Describe your changes and why you're making them. Please include the context, motivation, and relevant dependencies.

Resolves #3370

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation
  • Other - clean up email references for former contractors. No longer need email alerts ct-bdat-internal Slack thread

How has this been tested?

Post-merge follow-ups

Document any actions that must be taken post-merge to deploy or otherwise implement the changes in this PR (for example, running a full refresh of some incremental model in dbt). If these actions will take more than a few hours after the merge or if they will be completed by someone other than the PR author, please create a dedicated follow-up issue and link it here to track resolution.

  • No action required
  • Actions required (specified below)

@tiffanychu90 tiffanychu90 changed the title remove email references Offboarding - clean up email references Jun 24, 2024
Copy link

github-actions bot commented Jun 24, 2024

The following changes will be applied to the production Kubernetes cluster upon merge.

BE AWARE this may not reveal changes that have been manually applied to the cluster getting undone—applying manual changes to the cluster should be avoided.

No manifest changes found for prod.

@tiffanychu90
Copy link
Member Author

@evansiroky: can I remove this DAG completely because everyone in the email list is getting removed? Instead of an if/else to print a log, I can remove the entire DAG. Do I need to update anything else so I don't break Airflow?

@tiffanychu90
Copy link
Member Author

The following changes will be applied to the production Kubernetes cluster upon merge.

BE AWARE this may not reveal changes that have been manually applied to the cluster getting undone—applying manual changes to the cluster should be avoided.

No manifest changes found for prod.

@vevetron: Which change did I make to do this? How do I not kill Kubernetes cluster?

@vevetron
Copy link
Contributor

@evansiroky: can I remove this DAG completely because everyone in the email list is getting removed? Instead of an if/else to print a log, I can remove the entire DAG. Do I need to update anything else so I don't break Airflow?

I think it might be worth keeping the dag for possible future development.

Copy link
Contributor

@vevetron vevetron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vevetron
Copy link
Contributor

vevetron commented Jun 24, 2024

The following changes will be applied to the production Kubernetes cluster upon merge.
BE AWARE this may not reveal changes that have been manually applied to the cluster getting undone—applying manual changes to the cluster should be avoided.
No manifest changes found for prod.

@vevetron: Which change did I make to do this? How do I not kill Kubernetes cluster?

I'm not sure why this came up, I think everything is fine. Nobody is making manual changes to the kubernetes cluster as far as I know.

Copy link

github-actions bot commented Jun 24, 2024

The following changes will be applied to the production Kubernetes cluster upon merge.

BE AWARE this may not reveal changes that have been manually applied to the cluster getting undone—applying manual changes to the cluster should be avoided.

No manifest changes found for prod.

@tiffanychu90 tiffanychu90 merged commit cb55da1 into main Jun 24, 2024
5 checks passed
@tiffanychu90 tiffanychu90 deleted the offboarding branch June 24, 2024 22:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Offboard former Jarvus and Slalom and Caltrans staff
2 participants