Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check segments #816

Merged
merged 14 commits into from
Jul 26, 2023
Merged

Check segments #816

merged 14 commits into from
Jul 26, 2023

Conversation

tiffanychu90
Copy link
Member

@tiffanychu90 tiffanychu90 commented Jul 25, 2023

segment speeds

  • Do a comprehensive review of segments, especially look at how loop_or_inlining segments are, and whether improvements could be made Research Request - Plug in gaps in stop segments #811
  • Exploratory notebooks: 16_stop_combos_for_segments and 17_debug_empty_stop_segments
  • Several issues identified:
    • Multiple stop_sequences for different stop_ids present in a shape --> select 1 trip with most stops to cut segments for that shape
    • Gaps remain in between segments --> especially on curves and turns, the straight line distance underestimates (hypotenuse vs sum of 2 straight edges). add an extra check where the proposed end point is compared to original, and we tack on the leftover distance when we're subsetting the shape for the portion between 2 stops. marginal improvements, and making segments slightly longer won't hurt
    • Difficulty in segmenting loops near origin --> tried an extra super_project check to then try subsetting again using a combination of shape_geometry and altered/monotonically cast shape_geometry. this produced some improvements in problem segments, but also created more errors in otherwise correctly cut segments. forgo this approach because we don't want to create more issues than we're solving. incorrect segments are 1-2%.

@github-actions
Copy link

3 similar comments
@github-actions
Copy link

@github-actions
Copy link

@github-actions
Copy link

@tiffanychu90 tiffanychu90 linked an issue Jul 26, 2023 that may be closed by this pull request
@tiffanychu90 tiffanychu90 merged commit a08c8f6 into main Jul 26, 2023
2 checks passed
@tiffanychu90 tiffanychu90 deleted the check-segments branch July 26, 2023 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Research Request - Plug in gaps in stop segments
1 participant