-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Check segments #816
Merged
Merged
Check segments #816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…per_project hurts more than helps
nbviewer URLs for impacted notebooks: |
3 similar comments
nbviewer URLs for impacted notebooks: |
nbviewer URLs for impacted notebooks: |
nbviewer URLs for impacted notebooks: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
segment speeds
loop_or_inlining
segments are, and whether improvements could be made Research Request - Plug in gaps in stop segments #81116_stop_combos_for_segments
and17_debug_empty_stop_segments
stop_sequences
for differentstop_ids
present in a shape --> select 1 trip with most stops to cut segments for that shapesuper_project
check to then try subsetting again using a combination ofshape_geometry
and altered/monotonically castshape_geometry
. this produced some improvements in problem segments, but also created more errors in otherwise correctly cut segments. forgo this approach because we don't want to create more issues than we're solving. incorrect segments are 1-2%.