Micro-optimisation on array access

Reduces accessing two dimensions array eight times to once.
cakephp · May 2, 2024 · ace61b8 · ace61b8
1 parent 24fa232
commit ace61b8
Showing 1 changed file with 9 additions and 8 deletions.
diff --git a/CakePHP/Sniffs/Formatting/BlankLineBeforeReturnSniff.php b/CakePHP/Sniffs/Formatting/BlankLineBeforeReturnSniff.php
@@ -56,17 +56,18 @@ public function process(File $phpcsFile, $stackPtr)
         $prevLineTokens = [];
 
         while ($current >= 0 && $tokens[$current]['line'] >= $previousLine) {
+            $currentTokenCode = $tokens[$current]['code'];
             if (
                 $tokens[$current]['line'] == $previousLine
-                && $tokens[$current]['code'] !== T_WHITESPACE
-                && $tokens[$current]['code'] !== T_COMMENT
-                && $tokens[$current]['code'] !== T_DOC_COMMENT_OPEN_TAG
-                && $tokens[$current]['code'] !== T_DOC_COMMENT_TAG
-                && $tokens[$current]['code'] !== T_DOC_COMMENT_STRING
-                && $tokens[$current]['code'] !== T_DOC_COMMENT_CLOSE_TAG
-                && $tokens[$current]['code'] !== T_DOC_COMMENT_WHITESPACE
+                && $currentTokenCode !== T_WHITESPACE
+                && $currentTokenCode !== T_COMMENT
+                && $currentTokenCode !== T_DOC_COMMENT_OPEN_TAG
+                && $currentTokenCode !== T_DOC_COMMENT_TAG
+                && $currentTokenCode !== T_DOC_COMMENT_STRING
+                && $currentTokenCode !== T_DOC_COMMENT_CLOSE_TAG
+                && $currentTokenCode !== T_DOC_COMMENT_WHITESPACE
             ) {
-                $prevLineTokens[] = $tokens[$current]['code'];
+                $prevLineTokens[] = $currentTokenCode;
             }
             $current--;
         }