Fixed deadlock on IsNuGetPublished

[genriquez]

Whenever IsNuGetPublished is used with a source that returns a non-200 HTTP result, IsNugetPublished deadlocks and cake script stalls.

Description

Getting general resource information from the NuGet repository is not caught, failing in background. Happens with any non-200 HTTP result. Error is now trapped and dismissed in same way as other errors when fetching dependency info of the package.

Logging was added so users can see the actual error when using Diagnostic verbosity.

Original issue can be easily replicated with the following script:

#addin nuget:?package=Cake.ExtendedNuGet&version=5.0.0

Task("Test")
    .Does(ctx =>
    {    
        // Note the nuget URL is actually missing the `api.` subdomain
        var exists = ctx.IsNuGetPublished(new FilePath("test.nupkg"), "https://nuget.org/v3/index.json");
        Console.Write($"Package exists: {exists}");
    });

RunTarget("Test");

Motivation and Context

We are using private nuget repositories, which require user/password auth. API was replying with 401 causing the cake script to stall.

How Has This Been Tested?

Published locally and tested with our own private nuget repository.

Screenshots (if appropriate):

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

• My code follows the code style of this project.
• My change requires a change to the documentation.
• I have updated the documentation accordingly.
• I have read the CONTRIBUTING document.
• I have added tests to cover my changes.
• All new and existing tests passed.

[nils-a]

Thank you for getting this done, @genriquez.
Was there a specific reason you merged master into this PR?

[nils-a]

LGTM!

[nils-a]

@genriquez your changes have been merged, thanks for your contribution 👍

@augustoproiete thanks for getting this sorted!

[cake-contrib-bot]

🎉 This issue has been resolved in version 6.0.0 🎉
The release is available on:

• GitHub Release
• NuGet Package
  Your GitReleaseManager bot 📦🚀