Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix window selection #31

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

marcosolime
Copy link

@marcosolime marcosolime commented Oct 29, 2024

The way you pick valid windows does not seem correct. In your np.random.choice, you are providing as input the length of boolean mask (projs_window_valid_indx.shape[0]), corresponding to valid and invalid windows, but in this way you may pick also False windows.

Instead, you want to return the indices of valid windows only (torch.where). Then, you generate a random permutation of the valid indices and select the first self.window_num.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant