Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The way you pick valid windows does not seem correct. In your
np.random.choice
, you are providing as input the length of boolean mask (projs_window_valid_indx.shape[0]
), corresponding to valid and invalid windows, but in this way you may pick also False windows.Instead, you want to return the indices of valid windows only (
torch.where
). Then, you generate a random permutation of the valid indices and select the firstself.window_num
.