move panic to default case

cahirwpz · Jan 9, 2024 · a721744 · a721744
1 parent 6756a96
commit a721744
Show file tree

Hide file tree

Showing 3 changed files with 18 additions and 9 deletions.
diff --git a/include/aarch64/pmap.h b/include/aarch64/pmap.h
@@ -65,8 +65,9 @@ static __no_profile inline size_t pde_index(int lvl, vaddr_t va) {
       return L2_INDEX(va);
     case 3:
       return L3_INDEX(va);
+    default:
+      panic("Invalid level: %d", lvl);
   }
-  panic("Invalid level: %d", lvl);
 }
 
 static __no_profile inline bool pde_valid_index(int lvl, size_t index) {
@@ -77,8 +78,9 @@ static __no_profile inline bool pde_valid_index(int lvl, size_t index) {
     case 2:
     case 3:
       return index < Ln_ENTRIES;
+    default:
+      panic("Invalid level: %d", lvl);
   }
-  panic("Invalid level: %d", lvl);
 }
 
 static __no_profile inline size_t pde_size(int lvl) {
@@ -91,8 +93,9 @@ static __no_profile inline size_t pde_size(int lvl) {
       return L2_SIZE;
     case 3:
       return L3_SIZE;
+    default:
+      panic("Invalid level: %d", lvl);
   }
-  panic("Invalid level: %d", lvl);
 }
 
 /*

diff --git a/include/mips/pmap.h b/include/mips/pmap.h
@@ -89,8 +89,9 @@ static __no_profile inline size_t pde_index(int lvl, vaddr_t va) {
       return PDE_INDEX(va);
     case 1:
       return PTE_INDEX(va);
+    default:
+      panic("Invalid level: %d", lvl);
   }
-  panic("Invalid level: %d", lvl);
 }
 
 static __no_profile inline bool pde_valid_index(int lvl, size_t index) {
@@ -101,8 +102,9 @@ static __no_profile inline bool pde_valid_index(int lvl, size_t index) {
     case 2:
     case 3:
       return index < PT_ENTRIES;
+    default:
+      panic("Invalid level: %d", lvl);
   }
-  panic("Invalid level: %d", lvl);
 }
 
 static __no_profile inline size_t pde_size(int lvl) {
@@ -111,8 +113,9 @@ static __no_profile inline size_t pde_size(int lvl) {
       return PAGESIZE * PT_ENTRIES;
     case 1:
       return PAGESIZE;
+    default:
+      panic("Invalid level: %d", lvl);
   }
-  panic("Invalid level: %d", lvl);
 }
 
 /*

diff --git a/include/riscv/pmap.h b/include/riscv/pmap.h
@@ -62,8 +62,9 @@ static __no_profile inline size_t pde_index(int lvl, vaddr_t va) {
     case 2:
       return L2_INDEX(va);
 #endif
+    default:
+      panic("Invalid level: %d", lvl);
   }
-  panic("Invalid level: %d", lvl);
 }
 
 static __no_profile inline bool pde_valid_index(int lvl, size_t index) {
@@ -74,8 +75,9 @@ static __no_profile inline bool pde_valid_index(int lvl, size_t index) {
     case 2:
 #endif
       return index < Ln_ENTRIES;
+    default:
+      panic("Invalid level: %d", lvl);
   }
-  panic("Invalid level: %d", lvl);
 }
 
 static __no_profile inline size_t pde_size(int lvl) {
@@ -88,8 +90,9 @@ static __no_profile inline size_t pde_size(int lvl) {
     case 2:
       return L2_SIZE;
 #endif
+    default:
+      panic("Invalid level: %d", lvl);
   }
-  panic("Invalid level: %d", lvl);
 }
 
 /*