-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
updates to the project docs naming and organization + wrote new project setup instructions for dbt cloud #366
Conversation
…ct setup instructions for dbt cloud
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks Britt, the new documentation looks good with a few small corrections needed. I am getting 404s for the following:
images/environment_variables.png
local-setup.md
snowflake-project-setup.md
I am not sure why, it renders for me locally with no problem. |
If the files are present on your local branch but not github, is there any chance they aren't getting committed? |
Thanks for review and feedback @JamesSLogan! I think this is ready now |
Almost there -
I believe these 2 links need to be to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great
Thanks for catching and flagging those warnings @JamesSLogan and for all the feedback and review. |
Nice work @britt-allen! |
Thanks @ian-r-rose! |
fixes #275