-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Codespaces proof-of-concept #208
Conversation
"SNOWFLAKE_USER": { | ||
"description": "Your Snowflake Username" | ||
}, | ||
"SNOWFLAKE_PASSWORD": { | ||
"description": "Your Snowflake Password" | ||
}, | ||
"DBT_SCHEMA": { | ||
"description": "The dev schema into which to build your dbt models (e.g. DBT_<YOURNAME>)" | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These are the secrets that you need to set in order to do dbt-related work in the codespace
language: python | ||
entry: dbt deps --project-dir=transform | ||
language: system | ||
entry: poetry run dbt deps --project-dir transform |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Caught some real bugs in the pre-commit set-up when doing this!
mkdocs.yml
Outdated
- dbt: | ||
- Overview: dbt.md | ||
- dbt Performance: dbt-performance.md | ||
- dbt Snowflake Project: dbt_docs_snowflake/index.html | ||
- dbt BigQuery Project: dbt_docs_bigquery/index.html |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Drive-by change, organizing some of the dbt-related docs into a folder
82cfd7f
to
9c6d0fc
Compare
There are no instructions for what to do after you get to this screen. This screen comes immediately after clicking "New with options..." @ian-r-rose I assumed I should create a new branch so I did that and left the other defaults untouched. |
I did not have an option to add "Recommended Secrets" as the docs say immediately following creation of a codespace with options. This is the screen (below) I was taken to immediately after. It's unclear if I should expect to see the form listed in the docs or if I have to navigate to it. If the latter the instructions are lacking. |
Did you try to create the codespace from the |
You should go to the |
9c6d0fc
to
b7ee688
Compare
Wow this was SO easy, I am not sure whatever magic you did in the background, but this just works. Thanks @ian-r-rose. I cannot wait to show this off to future MDSA trainees. One question the docs doesn't answer: "Should we let Visual Studio Code periodically run |
Thanks for testing it out!
To be honest, I'm not sure what to recommend here, I don't really understand what the VS Code git extension does when you say yes. I suspect you are right that it's a personal preference thing, though I usually avoid automated git actions because (in my experience) it's an easy way to get into trouble with your git history.
I think you should still be able to run normal git operations, even if the extension is also doing things occasionally in the background. But I'm not 100% sure, having not really experimented with it myself. |
Fixes #203
Would appreciate feedback from @britt-allen or @matthewzhou. There is some documentation for how to set things up here