Minor cleanup #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
badsketch
commented
Sep 10, 2022
| } | ||
| else if (playerChoice == 'rock' && cpuChoice === 'paper') { | ||
| winnerOfRound = 'You lose! Paper beats rock!'; | ||
| console.log(winnerOfRound); | ||
| cpuButtonHighlight(cpuPaper); | ||
| cpuIncrementScore(cpuScore, cpuScoreElement); |
There was a problem hiding this comment.
these are global variables, so they don't need to be passed in as they're accessed directly.
badsketch
commented
Sep 10, 2022
| } | ||
| else if (playerChoice == 'rock' && cpuChoice === 'paper') { | ||
| winnerOfRound = 'You lose! Paper beats rock!'; | ||
| console.log(winnerOfRound); | ||
| cpuButtonHighlight(cpuPaper); | ||
| cpuIncrementScore(cpuScore, cpuScoreElement); | ||
| return changeBannerText(winnerOfRound); |
There was a problem hiding this comment.
I think best practice is that event handlers don't return a value
badsketch
commented
Sep 10, 2022
| console.log('The function cpuIncrementScore() is now running....'); | ||
| cpuScore++; | ||
| cpuScoreElement.innerHTML = `Score: ${cpuScore}`; | ||
| } | ||
| function playerCPUDraw(playerScore, cpuScore) { |
There was a problem hiding this comment.
I decided to remove this function, since nothing needs to happen if there's a draw. It's implicit, but sometimes explicit is good too, like what you did here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just some minor nits 🙂