Rework error handling #28
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, PCRE_ERROR_PARTIAL is bundled with other errors, making ExecPartialSoft and ExecPartialHard useless. The exec* family of methods now returns a Result, with two possible error cases: - A partial match occurred. - Some other error occurred. This is my first foray into Rust (outside tutorials and toy projects), so forgive me if anything isn't idiomatic. I'm happy to fix up the PR as-needed.
These were taken from pcre.h. Up next is to map them to ExecError (likely through `detail`).
We now panic only on rust-pcre internal errors, and provide an ExecError otherwise.
mrkline
force-pushed
the
rework-error-handling
branch
from
530981d to
33e9910
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a much more fleshed-out version of #25.
exec_*functions now return aResult, where theErrcase returns anExecError, indicating the problem. Some errors should be impossible given the preconditionsrust-pcreasserts before calling the relevantlibpcrefunctions, so we panic in those cases.