Skip to content

rework on poller auto scaler #1411

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 28 commits into from
Jun 25, 2025
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
9007db4
populate task for empty polls as well
shijiesheng Jan 16, 2025
f012e67
fix test case and revert task handler change
shijiesheng Jan 16, 2025
7d6d2f0
simply change
shijiesheng Jan 16, 2025
64374fa
rework on poller auto scaler
shijiesheng Dec 10, 2024
e010a49
add unit test
shijiesheng Dec 20, 2024
9e321fd
address incorrect scaling direction
shijiesheng Jan 2, 2025
346652b
address comment
shijiesheng Jan 3, 2025
35dd51c
process poller hint only when task is not nil
shijiesheng Jan 6, 2025
7ef8fed
use lock instead for transactions
shijiesheng Jan 7, 2025
d16cc77
bug fix on get auto config hint
shijiesheng Jan 7, 2025
ad2cc25
use worker type in logger and scope for autoscaler
shijiesheng Jan 7, 2025
ea7ec9d
correct locking
shijiesheng Jan 8, 2025
c9e4b29
address zero wait time
shijiesheng Jan 10, 2025
334e59b
process hint only for successful tasks
shijiesheng Jan 16, 2025
f297ab1
split scaling policy
shijiesheng Jan 17, 2025
56199fd
change default cooldown to 10s
shijiesheng Jan 17, 2025
c3a70cf
add a task interface
shijiesheng Feb 18, 2025
988ab8b
lint
shijiesheng Feb 18, 2025
5e63de8
populate autoconfig hint field
shijiesheng Jun 3, 2025
9323306
fix test
shijiesheng Jun 11, 2025
6e8d8bb
address comments except for exposing poller wait time and metrics fixing
shijiesheng Jun 17, 2025
124dfd6
changed metrics to histogram
shijiesheng Jun 17, 2025
855ab9f
add AutoscalerOptions and deprecate several first level WorkerOptions…
shijiesheng Jun 17, 2025
20e8d48
add comments on AutoScalerOptions
shijiesheng Jun 17, 2025
423be81
address most comments except for max poller settings
shijiesheng Jun 20, 2025
47da58b
handle max poller setting correctly
shijiesheng Jun 20, 2025
5a2c42f
fix unit test
shijiesheng Jun 24, 2025
7895fd4
change init count to top level max concurrent number of pollers to ke…
shijiesheng Jun 25, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
32 changes: 0 additions & 32 deletions internal/common/autoscaler/autoscaler.go

This file was deleted.

30 changes: 0 additions & 30 deletions internal/common/autoscaler/estimator.go

This file was deleted.

66 changes: 0 additions & 66 deletions internal/common/autoscaler/recommender.go

This file was deleted.

144 changes: 0 additions & 144 deletions internal/common/autoscaler/recommender_test.go

This file was deleted.

50 changes: 0 additions & 50 deletions internal/common/autoscaler/types.go

This file was deleted.

3 changes: 3 additions & 0 deletions internal/common/metrics/constants.go
Original file line number Diff line number Diff line change
Expand Up @@ -114,4 +114,7 @@ const (
ServerSideHistorySize = CadenceMetricsPrefix + "server-side-history-size"
ConcurrentTaskQuota = CadenceMetricsPrefix + "concurrent-task-quota"
PollerRequestBufferUsage = CadenceMetricsPrefix + "poller-request-buffer-usage"

// Concurrency Auto Scaler
ConcurrencyAutoScalerScope = CadenceMetricsPrefix + "concurrency-auto-scaler"
)
Loading