Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: update the linter action version #6575

Merged
merged 2 commits into from
Sep 16, 2024
Merged

ci: update the linter action version #6575

merged 2 commits into from
Sep 16, 2024

Conversation

mohammed90
Copy link
Member

🤞🏻

Signed-off-by: Mohammed Al Sahaf <[email protected]>
Copy link
Member

@mholt mholt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Definitely false positives on some of these, like complaining about out of bounds on this line:

return nil, fmt.Errorf("unsupported matcher data type: %s, %s", matcherDataTypes[0], matcherDataTypes[1])

yet the only way to get there is:

switch len(matcherDataTypes) {
// ...
	case 2:

So, disabling it approved, until they fix it.

@mholt mholt merged commit 6ab9fb6 into master Sep 16, 2024
33 checks passed
@mholt mholt deleted the lint-update branch September 16, 2024 13:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/CD 🔩 Automated tests, releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants