chore: use revive linter #5712
Closed
chore: use revive linter #5712
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
| @@ -630,7 +630,7 @@ func AdminAPIRequest(adminAddr, method, uri string, headers http.Header, body io | |||
| if err != nil { | |||
| return nil, fmt.Errorf("making request: %v", err) | |||
| } | |||
| if parsedAddr.IsUnixNetwork() { | |||
| if parsedAddr.IsUnixNetwork() { //nolint:revive | |||
There was a problem hiding this comment.
the revive linter prompts us to remove the empty code block that is currently just comments.
Comment on lines
772
to
+773
| var best []*Upstream | ||
| var bestReqs int = -1 | ||
| bestReqs := -1 |
There was a problem hiding this comment.
Nitpick but this is actually less symmetrical so it looks less nice. But whatever, it's fine.
Closed
|
I'll review again after the parent PRs are merged, hard to follow the diffs until then. |
|
Sorry, this one should be on draft for a minute. I may have revive configured a little too spicy. @francislavoie -- perfect <3 |
|
I think this PR is no longer needed. Prefer #5709 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables the revive linter, and should be merged after gci and gofumpt, since it contains them.
Contains